Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distro-agnostic compatibility with GCC 13 #514

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

nadimkobeissi
Copy link
Contributor

Rework of #512, which targeted main instead of develop.

The zkevm-prover currently will not compile under the most used desktop Linux distributions. A notable exception is Ubuntu 22.04, since that is what a lot of developers in the Polygon Labs zkEVM Prover Team use.

This leads to problems:

As such, it's very important to make the repository agnostic to:

  • Which Linux distro I'm using,
  • Which version of GCC I'm using,
  • Which version of protobuf I'm using. etc.

...which is what this pull request does.

This pull request also provides an improved README.md which includes:

  • Improved grammar and sentence structure everywhere.
  • Better organization.
  • Instructions for dependencies on openSUSE and Arch.

Finally, this pull request provides better tooling for downloading that gargantuan 75GB archive that we need to get the prover working.

A separate pull request for a submodule dependency (goldilocks) has already been merged and fixes this same problem (which appeared in a much less pronounced fashion) over there: 0xPolygonHermez/goldilocks#42

This pull request has been fully tested locally.

@nadimkobeissi nadimkobeissi self-assigned this Aug 22, 2023
@cla-bot cla-bot bot added the cla-signed label Aug 22, 2023
tools/download_archive.sh Outdated Show resolved Hide resolved
tools/download_archive.sh Show resolved Hide resolved
tools/download_archive.sh Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@eduadiez eduadiez requested a review from fractasy August 22, 2023 19:33
@nadimkobeissi
Copy link
Contributor Author

@eduadiez Your proposed changes have been implemented in 3333e99.

@eduadiez eduadiez self-requested a review August 23, 2023 15:58
@fractasy fractasy merged commit f660c8a into develop Aug 24, 2023
2 checks passed
@nadimkobeissi nadimkobeissi deleted the nadim-fixcompile-develop branch August 24, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants