Rename "Night mode" to "Dark theme" issue #5169

[arcadioramos]

I renamed all the files with night mode to the dark theme as the issue said :)
issue #5169

[alya]

@arcadioramos I noticed that you made some changes in capitalization. Please update PR to keep capitalization consistent -- we're just changing the name.

Perhaps @chrisbobbe or @gnprice can comment on other aspects of the PR, e.g whether translations are being handled correctly.

[chrisbobbe]

Thanks, @arcadioramos! 🙂

Perhaps @chrisbobbe or @gnprice can comment on other aspects of the PR, e.g whether translations are being handled correctly.

Please only change static/translations/messages_en.json, not the other files in static/translations. Those will sync automatically when we (the maintainers) run tools/tx-sync later; see our translation doc.

[arcadioramos]

So the only change I should do is in that specific file? @chrisbobbe

[chrisbobbe]

So the only change I should do is in that specific file? @chrisbobbe

Ah, sorry, I was unclear: the only file in static/translations that you should change is static/translations/messages_en.json.

I see other changes outside static/translations. Those look good (keep them), except you should apply Alya's feedback about capitalization.

[arcadioramos]

Done @chrisbobbe, I applied @alya feedback and the one you gave me

[arcadioramos]

I don't know why this is failing, I did what that CI told me to do and it is still failing

[chrisbobbe]

I did what that CI told me to do and it is still failing

Can you explain this in more detail, please?

You should run tools/test locally, fix the issues it reports, and then push the fixed commits to GitHub. The CI checks will then run again.