chore: rename night mode to dark theme

[Udit-takkar]

#5169
Renamed all the files to dark theme .

Last inactive open PR #5170.
I have run all the tests and also changed some more files that were not addressed in last PR

[Udit-takkar]

It is ready to be reviewed @chrisbobbe

[chrisbobbe]

src/api/initialDataTypes.js has our Flow types that represent the data we expect to receive from servers. We should only change those types if

• they've been doing their job badly (they were written without understanding what servers are actually sending)
• new servers have started sending different data, and we want to start representing the new data.

I don't think either of those applies here. (If that's wrong, please talk about why you think so. 🙂) So we should leave those types unchanged, and Flow will lead you to undo several follow-on changes you made. Thanks!

[Udit-takkar]

src/api/initialDataTypes.js has our Flow types that represent the data we expect to receive from servers. We should only change those types if

• they've been doing their job badly (they were written without understanding what servers are actually sending)
• new servers have started sending different data, and we want to start representing the new data.

I don't think either of those applies here. (If that's wrong, please talk about why you think so. 🙂) So we should leave those types unchanged, and Flow will lead you to undo several follow-on changes you made. Thanks!

Okay you are right. Thanks for reviewing

[Udit-takkar]

@chrisbobbe is it fine now?

[gnprice]

Thanks @Udit-takkar! Some comments below.

Also please take a look at the Zulip project's guide on how to make a clean commit history:
https://zulip.readthedocs.io/en/latest/contributing/version-control.html

In particular, rather than having one commit with a bug and a commit later in the PR that fixes it, we ask that you squash the fix to make one commit that doesn't have the bug. So in this PR, your three commits so far should be squashed together as one commit.

[gnprice]

This is a historical changelog entry (from 2019), so let's leave it in the form we used at the time.

[Udit-takkar]

Okay

[Udit-takkar]

Okay @gnprice did all the changes you suggested and cleaned the git history