Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set branch protection rules. #207

Merged
merged 13 commits into from
May 6, 2024
Merged

Set branch protection rules. #207

merged 13 commits into from
May 6, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Sep 22, 2023 •
edited
Loading

See #191

@icemac icemac self-assigned this Sep 22, 2023
@dataflake
Copy link
Member

Does the branch protection script make sure that the "Release Managers" group can override restrictions such as pushing directly to master?

@icemac icemac mentioned this pull request Apr 16, 2024
Merged
@icemac icemac mentioned this pull request Apr 26, 2024
Merged
@icemac icemac marked this pull request as ready for review April 26, 2024 07:34
@icemac
Copy link
Member Author

icemac commented Apr 26, 2024

Does the branch protection script make sure that the "Release Managers" group can override restrictions such as pushing directly to master?

No, this is not yet done. But I want to get it merged first and then I can add it.

@icemac icemac requested a review from dataflake April 26, 2024 07:34
@icemac icemac added the enhancement New feature or request label Apr 26, 2024
@icemac icemac changed the title WIP: Set branch protection. Set branch protection rules. Apr 26, 2024
@icemac icemac mentioned this pull request Apr 26, 2024
Open
dataflake
dataflake approved these changes Apr 26, 2024
View reviewed changes
config/shared/call.py Outdated Show resolved Hide resolved
@dataflake
Copy link
Member

With the typo I pointed out fixed this should be merged because I already keep using it due to the (unrelated) changes in GHA runner versions.

@icemac @dataflake
Update config/shared/call.py
352ee9f 
Co-authored-by: Jens Vagelpohl <[email protected]>
@icemac icemac merged commit 93902d8 into master May 6, 2024
3 checks passed
@icemac icemac deleted the re-191/branch-protection branch May 6, 2024 06:38
@icemac
Copy link
Member Author

icemac commented May 6, 2024

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

Assignees

@icemac icemac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @dataflake