Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GHA #108

Merged
merged 10 commits into from
May 8, 2024
Merged

Windows GHA #108

merged 10 commits into from
May 8, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 25, 2024

No description provided.

@icemac icemac self-assigned this Apr 25, 2024
@icemac icemac requested a review from dataflake April 25, 2024 06:38
@dataflake
Copy link
Member

It looks like the definition for macos-latest has changed since last week when the tests ran fine on this branch. It moved from version 12.7.4 to version 14.4.1.

The macOS 12.7.4 runners apparently had pre-installed binaries for Python 3.7 through 3.12, the Python setup action did not have to check the versions manifest (https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json) to find suitable downloads.

The macOS 14.4.1 runner only has Python 3.11 and up pre-installed, all older versions are downloaded and built with data from the Python versions manifest. This version manifest shows no arm64 Python 3.7 build.

A solution could be to force the older macOS runner for Python 3.7 or drop building wheels and testing for Python 3.7 on macOS.

@icemac
Copy link
Member Author

icemac commented Apr 26, 2024

Maybe it is time to drop support for Python 3.7, as it has reached its end of life at 2023-06-27.

@icemac
Copy link
Member Author

icemac commented Apr 26, 2024

@dataflake But for now it seems to be easier to fix it like you suggested. We have to many open issues to also add dropping 3.7 support right now.

@dataflake
Copy link
Member

Can you remind me since this macos-latest is not in the meta repo master: Did you use some meta repo branch to create the test matrix here?

@icemac
Copy link
Member Author

icemac commented Apr 26, 2024

@dataflake I am using zopefoundation/meta#207 here and my current goal is to make it ready to be merged.

@dataflake
Copy link
Member

OK, I'll add the changes there and run it against this package again

@dataflake
Copy link
Member

With the change in zopefoundation/meta@c0bfa85 the build and test runs again. When this is merged the branch protection rule for master in this repository needs to be changed, it still expects a check for Python 3.7 on macos-latest.

@icemac icemac enabled auto-merge (squash) May 8, 2024 06:57
@icemac icemac merged commit 1e9421a into master May 8, 2024
52 checks passed
@icemac icemac deleted the windows-gha branch May 8, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants