Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to publish panoptes.js #1082

Merged
merged 8 commits into from
Sep 18, 2019
Merged

Prepare to publish panoptes.js #1082

merged 8 commits into from
Sep 18, 2019

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Aug 19, 2019

Package: lib-panoptes-js

This does three things:

  • Reorganizes and updates the documentation. The docs are now readme files in the file structure itself which should make it easier to find I think and follows the pattern we've done elsewhere.
  • Adds query param support to put and post in the least disruptive way I could think of (since put and post are being used in the UPP store) and specifically tests for the functionality to use the env query param to set the host across the board
  • Removes the unused tutorial request helper for getting the attached media via an include. Deprecating the include param is requested in remove API include requests #678. We still need to deprecate project's helper getWithLinkedResources but this is being used in the project app, so it'll be best to do that on its own with a refactor in the project app and a major version bump when this happens.

I plan to do an initial published release of a minor version, 0.1.0

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?
  • Is the changelog updated?

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && yarn bootstrap and app works as expected?
  • Can you run a production build of the app?

@srallen srallen added the dependencies Pull requests that update a dependency file label Aug 19, 2019
@srallen srallen requested a review from a team August 19, 2019 21:08
Copy link
Contributor

@rogerhutchings rogerhutchings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm still struggling to run the classifier at the moment. While I look into it again, I'm going to ask someone else to approve it.

@rogerhutchings rogerhutchings merged commit 5e7a1f2 into master Sep 18, 2019
@rogerhutchings rogerhutchings deleted the publish-panoptes-js branch September 18, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants