Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the env query param to POST and PUT #624

Closed
srallen opened this issue Mar 28, 2019 · 2 comments
Closed

Add support for the env query param to POST and PUT #624

srallen opened this issue Mar 28, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@srallen
Copy link
Contributor

srallen commented Mar 28, 2019

Package lib-panoptes-js

Feature or Issue Description
For SSR, we pass along the env query param to set which host to use for the client. POST and PUT still need to be updated to support this. Related to #612

@srallen srallen added the enhancement New feature or request label Mar 28, 2019
@srallen srallen added this to the TESS beta milestone Mar 28, 2019
@eatyourgreens
Copy link
Contributor

More generally, we support query params on PUT and POST in the existing client so we should allow them in the new client too.
https://github.com/zooniverse/json-api-client/blob/6398c84b23c1a1379f2df48915051218c69f2972/src/make-http-request.coffee#L32-L33

@srallen
Copy link
Contributor Author

srallen commented Nov 15, 2019

Done in #1082

@srallen srallen closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants