Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle looping for Android #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pawlowskim
Copy link

It's fresh merge for #213 . My previous commit was in 2017 so I created a new clean fork and added my changes. Unfortunately I don't have time to test it right now. So please @paulmelnikow test it before merging - it worked back then :)

@paulmelnikow
Copy link
Collaborator

Thanks! I will test this when I can. Meanwhile if anyone else can test this and post a report, that would help this get merged faster!

@chetstone
Copy link

I tried this in my app: I got java compilation errors:

> Task :RNSound:compileDebugJavaWithJavac FAILED
/Users/maint/prj/malas/upgrade/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/RNSoundModule.java:244: error: cannot find symbol
                  if (this.loops > 0) {
                          ^
  symbol: variable loops
/Users/maint/prj/malas/upgrade/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/RNSoundModule.java:246: error: cannot find symbol
                        this.loops--;
                            ^
  symbol: variable loops
Note: /Users/maint/prj/malas/upgrade/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/RNSoundModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors

FAILURE: Build failed with an exception.

@pawlowskim
Copy link
Author

@chetstone as I said, I didn't tested it at all. I have released a fix that builds. Could you test it? https://github.com/pawlowskim/react-native-sound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants