Handle looping for Android #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-same api as for iOS
|
@pawlowskim Thanks for this. Could you try to apply your changes again without all the formatting updates? It's difficult to keep track of changes if the whole file is reformatted |
|
@benvium Second commit should keep old formatting. |
benvium
reviewed
Jun 23, 2017
| @@ -258,3 +255,39 @@ public void enable(final Boolean enabled) { | |||
| return constants; | |||
| } | |||
| } | |||
|
|
|||
| class OnCompletionListenerLooped implements OnCompletionListener { | |||
There was a problem hiding this comment.
Probably best to be static class OnCompletionListenerLooped
There was a problem hiding this comment.
Why static? Nobody gonna use it outside the RNSoundModule and static is little heavier than private. Isn't it? I'm not java master.
|
Hi! Thank you for this! If you'd like to rebase this work onto latest master I'd be happy to get it merged! 😀 |
|
@paulmelnikow This PR is too old. I have created new one: #586 I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I needed looping on Android to works the same way as for iOS. I changed current onCompletionListener with custom one, that handles loops. Api is the same for iOS and Android. I'm not java master so any suggestion will be appreciated.
Sorry for formatting :/