Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for validating HMC server certificates #178

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented May 19, 2021

See commit message.
Will require zhmcclient 0.31, currently from its master branch.

@zhmcclient zhmcclient deleted a comment from GitCop May 19, 2021
@andy-maier andy-maier self-assigned this May 19, 2021
@andy-maier andy-maier requested a review from vkathir82 May 19, 2021 21:57
@andy-maier andy-maier added this to the 0.22.0 milestone May 19, 2021
@andy-maier andy-maier linked an issue May 19, 2021 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 19, 2021

Coverage Status

Coverage decreased (-0.06%) to 36.875% when pulling 9a63bab on andy/add-verify into 80c1931 on master.

Details:

* The zhmc command now verifies HMC server certificates by default, using the
  CA certificates in the 'certifi' Python package. This verification will
  reject the self-signed certificates the HMC is set up with initially. To
  deal with this, install a CA-verifiable certificate in the HMC and specify
  the correct CA certificates with the new '-c / --ca-certs' option. As a
  temporary quick fix, you can disable the verification with the new '-n /
  --no-verify' option.

* The zhmc command now supports verification of the HMC server certificate.
  There are two new command line options '-n / --no-verify' and '-c /
  --ca-certs' that control the verification behavior.

Signed-off-by: Andreas Maier <[email protected]>
@vkathir82 vkathir82 merged commit 7c5b4fd into master Jun 5, 2021
@vkathir82 vkathir82 deleted the andy/add-verify branch June 5, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for HMC certificate validation
3 participants