Certificate verification, part 2 #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/verify-part2
branch
from
fc9322a to
d0ba550
Compare
andy-maier
force-pushed
the
andy/verify-part2
branch
from
d0ba550 to
2bd8aee
Compare
Details: * Changed default to verify the HMC certificate. * Documented how the REQUESTS_CA_BUNDLE and CURL_CA_BUNDLE env vars are used. * Other documentation improvements in the HMC certificate section. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/verify-part2
branch
from
2bd8aee to
9a30f28
Compare
vkathir82
approved these changes
Jun 5, 2021
|
Merging, since all packages now have PRs with certificate support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR changes the default for the recently added
verify_certparameter ofzhmcclient.Sessionto True, which is an incompatible change.The new default value of True will cause the HMC server certificate to be validated against the CA certificates in the 'certifi' package. If you run the HMC with self-signed certificates, or if its certificate has a certificate chain not covered by the 'certifi' package, communication with the HMC will fail.
This PR should not be merged until we have extended all zhmcclient packages to support HMC certificate validation:
For details, see the commit message.