Added support for verifying HMC certificates #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/verify-certs
branch
4 times, most recently
from
f4ef475 to
1400ba4
Compare
Details: * Added module sub-parameters 'ca_certs' and 'verify' to the 'hmc_auth' module parameter of all modules. (issue #401) * Changed module input parameter 'hmc_auth.userid' to no longer be hidden in logs, for better debugging. The password is still hidden in any logs. * Increased minimum version of zhmcclient to 0.31.0 in order to have the support for certificate verification. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/verify-certs
branch
from
1400ba4 to
bc1b459
Compare
vkathir82
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
I manually tested the new module input parameters in all variations and with several error cases.