Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to main (v2.11.2) #1957

Merged
merged 2 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "zenstack-monorepo",
"version": "2.11.1",
"version": "2.11.2",
"description": "",
"scripts": {
"build": "pnpm -r --filter=\"!./packages/ide/*\" build",
Expand Down
2 changes: 1 addition & 1 deletion packages/ide/jetbrains/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

group = "dev.zenstack"
version = "2.11.1"
version = "2.11.2"

repositories {
mavenCentral()
Expand Down
2 changes: 1 addition & 1 deletion packages/ide/jetbrains/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jetbrains",
"version": "2.11.1",
"version": "2.11.2",
"displayName": "ZenStack JetBrains IDE Plugin",
"description": "ZenStack JetBrains IDE plugin",
"homepage": "https://zenstack.dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/language/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/language",
"version": "2.11.1",
"version": "2.11.2",
"displayName": "ZenStack modeling language compiler",
"description": "ZenStack modeling language compiler",
"homepage": "https://zenstack.dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/misc/redwood/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/redwood",
"displayName": "ZenStack RedwoodJS Integration",
"version": "2.11.1",
"version": "2.11.2",
"description": "CLI and runtime for integrating ZenStack with RedwoodJS projects.",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/openapi/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/openapi",
"displayName": "ZenStack Plugin and Runtime for OpenAPI",
"version": "2.11.1",
"version": "2.11.2",
"description": "ZenStack plugin and runtime supporting OpenAPI",
"main": "index.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/swr/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/swr",
"displayName": "ZenStack plugin for generating SWR hooks",
"version": "2.11.1",
"version": "2.11.2",
"description": "ZenStack plugin for generating SWR hooks",
"main": "index.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/tanstack-query/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/tanstack-query",
"displayName": "ZenStack plugin for generating tanstack-query hooks",
"version": "2.11.1",
"version": "2.11.2",
"description": "ZenStack plugin for generating tanstack-query hooks",
"main": "index.js",
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/trpc/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/trpc",
"displayName": "ZenStack plugin for tRPC",
"version": "2.11.1",
"version": "2.11.2",
"description": "ZenStack plugin for tRPC",
"main": "index.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/runtime",
"displayName": "ZenStack Runtime Library",
"version": "2.11.1",
"version": "2.11.2",
"description": "Runtime of ZenStack for both client-side and server-side environments.",
"repository": {
"type": "git",
Expand Down
10 changes: 8 additions & 2 deletions packages/runtime/src/enhancements/node/policy/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,14 @@ export class PolicyProxyHandler<DbClient extends DbClientContract> implements Pr
let result: { result: unknown; error?: Error }[];

if (!shouldConvertToCreate) {
// direct `createManyAndReturn`
const created = await this.modelClient.createManyAndReturn(args);
// direct `createManyAndReturn`, make sure we only select id fields for return
// so we can use the results directly for read-back check
const updatedArgs = {
...args,
select: this.policyUtils.makeIdSelection(this.model),
include: undefined,
};
const created = await this.modelClient.createManyAndReturn(updatedArgs);

// process read-back
result = await Promise.all(
Expand Down
2 changes: 1 addition & 1 deletion packages/schema/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"publisher": "zenstack",
"displayName": "ZenStack Language Tools",
"description": "FullStack enhancement for Prisma ORM: seamless integration from database to UI",
"version": "2.11.1",
"version": "2.11.2",
"author": {
"name": "ZenStack Team"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/sdk",
"version": "2.11.1",
"version": "2.11.2",
"description": "ZenStack plugin development SDK",
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/server",
"version": "2.11.1",
"version": "2.11.2",
"displayName": "ZenStack Server-side Adapters",
"description": "ZenStack server-side adapters",
"homepage": "https://zenstack.dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/testtools/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/testtools",
"version": "2.11.1",
"version": "2.11.2",
"description": "ZenStack Test Tools",
"main": "index.js",
"private": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,17 @@ describe('Test API createManyAndReturn', () => {

const db = enhance();

// create should succeed but one result can't be read back
await expect(
db.post.createManyAndReturn({
data: [
{ title: 'post1', published: true },
{ title: 'post2', published: false },
],
})
).toBeRejectedByPolicy();
// create should succeed but one result's title field can't be read back
const r = await db.post.createManyAndReturn({
data: [
{ title: 'post1', published: true },
{ title: 'post2', published: false },
],
});

expect(r.length).toBe(2);
expect(r[0].title).toBeTruthy();
expect(r[1].title).toBeUndefined();

// check posts are created
await expect(prisma.post.findMany()).resolves.toHaveLength(2);
Expand Down
97 changes: 97 additions & 0 deletions tests/regression/tests/issue-1955.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
import { createPostgresDb, dropPostgresDb, loadSchema } from '@zenstackhq/testtools';

describe('issue 1955', () => {
it('simple policy', async () => {
const dbUrl = await createPostgresDb('issue-1955-1');
let _prisma: any;

try {
const { enhance, prisma } = await loadSchema(
`
model Post {
id Int @id @default(autoincrement())
name String
expections String[]

@@allow('all', true)
}
`,
{ provider: 'postgresql', dbUrl }
);
_prisma = prisma;

const db = enhance();
await expect(
db.post.createManyAndReturn({
data: [
{
name: 'bla',
},
{
name: 'blu',
},
],
})
).resolves.toEqual(
expect.arrayContaining([
expect.objectContaining({ name: 'bla' }),
expect.objectContaining({ name: 'blu' }),
])
);
} finally {
await _prisma.$disconnect();
await dropPostgresDb('issue-1955-1');
}
});

it('complex policy', async () => {
const dbUrl = await createPostgresDb('issue-1955-2');
let _prisma: any;

try {
const { enhance, prisma } = await loadSchema(
`
model Post {
id Int @id @default(autoincrement())
name String
expections String[]
comments Comment[]

@@allow('all', comments^[private])
}

model Comment {
id Int @id @default(autoincrement())
private Boolean @default(false)
postId Int
post Post @relation(fields: [postId], references: [id])
}
`,
{ provider: 'postgresql', dbUrl }
);
_prisma = prisma;

const db = enhance();
await expect(
db.post.createManyAndReturn({
data: [
{
name: 'bla',
},
{
name: 'blu',
},
],
})
).resolves.toEqual(
expect.arrayContaining([
expect.objectContaining({ name: 'bla' }),
expect.objectContaining({ name: 'blu' }),
])
);
} finally {
await _prisma.$disconnect();
await dropPostgresDb('issue-1955-2');
}
});
});
Loading