merge dev to main (v2.11.2) #1957
Conversation
…n the model contains array fields (#1956)
|
Warning Rate limit exceeded@ymc9 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request encompasses changes across multiple files, primarily focusing on version update and policy handling modifications. The main changes include updating the version to "2.11.2" in the JetBrains plugin build configuration, enhancing the Changes
Sequence DiagramsequenceDiagram
participant PolicyHandler
participant ModelClient
participant PolicyUtils
PolicyHandler->>PolicyUtils: makeIdSelection(model)
PolicyUtils-->>PolicyHandler: return selected ID fields
PolicyHandler->>ModelClient: createManyAndReturn(updatedArgs)
ModelClient-->>PolicyHandler: return results with only ID fields
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
tests/regression/tests/issue-1955.test.ts (2)
14-14: Fix typo in field name.The field name 'expections' appears to be a typo of 'exceptions'.
- expections String[] + exceptions String[]Also applies to: 57-57
24-40: Enhance test coverage.The test assertions could be more comprehensive:
- Verify the 'exceptions' field is present and correctly populated
- Add test cases for error scenarios
- Test the behavior when invalid data is provided
Example enhancement:
await expect( db.post.createManyAndReturn({ data: [ { name: 'bla', exceptions: ['error1'], }, { name: 'blu', exceptions: ['error2'], }, ], }) ).resolves.toEqual( expect.arrayContaining([ expect.objectContaining({ name: 'bla', exceptions: ['error1'], }), expect.objectContaining({ name: 'blu', exceptions: ['error2'], }), ]) ); // Add error case await expect( db.post.createManyAndReturn({ data: [ { name: '', // Invalid empty name }, ], }) ).rejects.toThrow();Also applies to: 75-91
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (13)
package.jsonis excluded by!**/*.jsonpackages/ide/jetbrains/package.jsonis excluded by!**/*.jsonpackages/language/package.jsonis excluded by!**/*.jsonpackages/misc/redwood/package.jsonis excluded by!**/*.jsonpackages/plugins/openapi/package.jsonis excluded by!**/*.jsonpackages/plugins/swr/package.jsonis excluded by!**/*.jsonpackages/plugins/tanstack-query/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/package.jsonis excluded by!**/*.jsonpackages/runtime/package.jsonis excluded by!**/*.jsonpackages/schema/package.jsonis excluded by!**/*.jsonpackages/sdk/package.jsonis excluded by!**/*.jsonpackages/server/package.jsonis excluded by!**/*.jsonpackages/testtools/package.jsonis excluded by!**/*.json
📒 Files selected for processing (4)
packages/ide/jetbrains/build.gradle.kts(1 hunks)packages/runtime/src/enhancements/node/policy/handler.ts(1 hunks)tests/integration/tests/enhancements/with-policy/create-many-and-return.test.ts(1 hunks)tests/regression/tests/issue-1955.test.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/ide/jetbrains/build.gradle.kts
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: OSSAR-Scan
- GitHub Check: dependency-review
- GitHub Check: OSSAR-Scan
🔇 Additional comments (3)
tests/regression/tests/issue-1955.test.ts (1)
41-45: LGTM! Proper error handling and cleanup.The try/finally blocks ensure proper cleanup of database resources, even if the test fails.
Also applies to: 92-96
tests/integration/tests/enhancements/with-policy/create-many-and-return.test.ts (1)
95-105: LGTM! Clear and precise test assertions.The test clearly demonstrates the expected behavior:
- Successfully creates two posts
- Verifies that the title field is accessible only when
publishedis true- Confirms that both posts are created regardless of field-level access
packages/runtime/src/enhancements/node/policy/handler.ts (1)
481-488: LGTM! Improved field selection for policy checks.The changes ensure that only ID fields are selected for return, which is essential for proper read-back checks. The explicit setting of
include: undefinedprevents unintended relation loading.
No description provided.