Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to main (v2.1.1) #1453

Merged
merged 3 commits into from
May 15, 2024
Merged

merge dev to main (v2.1.1) #1453

merged 3 commits into from
May 15, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented May 15, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

Walkthrough

The recent updates involve enhancements and fixes across various components of the ZenStack project. Key changes include support for using ZModel type names as model field names, improved schema file resolution for auth(), and the release of ZenStack V2. Additionally, the build.gradle.kts version was incremented, an auth entity was added to enhance.d.ts, and recursion logic was adjusted in PolicyUtil to prevent infinite loops. A new regression test was also introduced.

Changes

File Path Summary
packages/ide/jetbrains/CHANGELOG.md Added support for ZModel type names as model field names and resolved auth() from all reachable schema files.
packages/ide/jetbrains/build.gradle.kts Updated version from 2.1.0 to 2.1.1.
packages/runtime/res/enhance.d.ts Exported auth alongside enhance from .zenstack/enhance.
packages/runtime/src/enhancements/policy/policy-utils.ts Modified injectReadCheckSelect to recurse into relation fields first to prevent infinite recursion.
tests/regression/tests/issue-1451.test.ts Introduced a new regression test case for issue 1452 focusing on schema loading and data manipulation using Prisma ORM.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Out of diff range and nitpick comments (3)
packages/ide/jetbrains/CHANGELOG.md (3)

Line range hint 13-13: Headings should be surrounded by blank lines for better readability.

-### Fixed
+### Fixed

Line range hint 14-14: The preposition “for” seems more likely in this position than the preposition “to”.

-Added support to complex usage of `@@index` attribute like `@@index([content(ops: raw("gin_trgm_ops"))], type: Gin)`.
+Added support for complex usage of `@@index` attribute like `@@index([content(ops: raw("gin_trgm_ops"))], type: Gin)`.

Line range hint 15-15: Possible typo: you repeated a word.

-Fixed several ZModel validation issues related to model inheritance.
+Fixed several ZModel validation issues related to model inheritance.
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3588a36 and 29962e0.
Files ignored due to path filters (13)
  • package.json is excluded by !**/*.json
  • packages/ide/jetbrains/package.json is excluded by !**/*.json
  • packages/language/package.json is excluded by !**/*.json
  • packages/misc/redwood/package.json is excluded by !**/*.json
  • packages/plugins/openapi/package.json is excluded by !**/*.json
  • packages/plugins/swr/package.json is excluded by !**/*.json
  • packages/plugins/tanstack-query/package.json is excluded by !**/*.json
  • packages/plugins/trpc/package.json is excluded by !**/*.json
  • packages/runtime/package.json is excluded by !**/*.json
  • packages/schema/package.json is excluded by !**/*.json
  • packages/sdk/package.json is excluded by !**/*.json
  • packages/server/package.json is excluded by !**/*.json
  • packages/testtools/package.json is excluded by !**/*.json
Files selected for processing (5)
  • packages/ide/jetbrains/CHANGELOG.md (1 hunks)
  • packages/ide/jetbrains/build.gradle.kts (1 hunks)
  • packages/runtime/res/enhance.d.ts (1 hunks)
  • packages/runtime/src/enhancements/policy/policy-utils.ts (2 hunks)
  • tests/regression/tests/issue-1451.test.ts (1 hunks)
Files skipped from review due to trivial changes (2)
  • packages/ide/jetbrains/build.gradle.kts
  • tests/regression/tests/issue-1451.test.ts
Additional Context Used
LanguageTool (3)
packages/ide/jetbrains/CHANGELOG.md (3)

Near line 13: Possible typo: you repeated a word
Context: ...d - ZenStack V2 release! ## 1.11.0 ### Added - Added support to complex usage of @@index a...


Near line 14: The preposition “for” seems more likely in this position than the preposition “to”.
Context: ...e! ## 1.11.0 ### Added - Added support to complex usage of @@index attribute li...


Near line 15: Possible typo: you repeated a word
Context: ...raw("gin_trgm_ops"))], type: Gin)`. ### Fixed - Fixed several ZModel validation issues relate...

Additional comments not posted (2)
packages/runtime/res/enhance.d.ts (1)

1-1: LGTM! The addition of auth to the export statement is correct.

packages/runtime/src/enhancements/policy/policy-utils.ts (1)

963-965: The change to recurse into relation fields before injecting the current level is a good improvement to prevent infinite recursion. Ensure this logic is thoroughly tested.

Please verify that this change has been thoroughly tested to ensure it prevents infinite recursion without introducing new issues.

packages/ide/jetbrains/CHANGELOG.md Show resolved Hide resolved
packages/ide/jetbrains/CHANGELOG.md Show resolved Hide resolved
packages/ide/jetbrains/CHANGELOG.md Show resolved Hide resolved
packages/ide/jetbrains/CHANGELOG.md Show resolved Hide resolved
packages/ide/jetbrains/CHANGELOG.md Show resolved Hide resolved
packages/ide/jetbrains/CHANGELOG.md Show resolved Hide resolved
@ymc9 ymc9 added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit fea8ec7 May 15, 2024
16 checks passed
This was referenced Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant