-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge dev to main (v2.1.1) #1453
Conversation
WalkthroughWalkthroughThe recent updates involve enhancements and fixes across various components of the ZenStack project. Key changes include support for using ZModel type names as model field names, improved schema file resolution for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Out of diff range and nitpick comments (3)
packages/ide/jetbrains/CHANGELOG.md (3)
Line range hint
13-13
: Headings should be surrounded by blank lines for better readability.-### Fixed +### Fixed
Line range hint
14-14
: The preposition “for” seems more likely in this position than the preposition “to”.-Added support to complex usage of `@@index` attribute like `@@index([content(ops: raw("gin_trgm_ops"))], type: Gin)`. +Added support for complex usage of `@@index` attribute like `@@index([content(ops: raw("gin_trgm_ops"))], type: Gin)`.
Line range hint
15-15
: Possible typo: you repeated a word.-Fixed several ZModel validation issues related to model inheritance. +Fixed several ZModel validation issues related to model inheritance.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (13)
package.json
is excluded by!**/*.json
packages/ide/jetbrains/package.json
is excluded by!**/*.json
packages/language/package.json
is excluded by!**/*.json
packages/misc/redwood/package.json
is excluded by!**/*.json
packages/plugins/openapi/package.json
is excluded by!**/*.json
packages/plugins/swr/package.json
is excluded by!**/*.json
packages/plugins/tanstack-query/package.json
is excluded by!**/*.json
packages/plugins/trpc/package.json
is excluded by!**/*.json
packages/runtime/package.json
is excluded by!**/*.json
packages/schema/package.json
is excluded by!**/*.json
packages/sdk/package.json
is excluded by!**/*.json
packages/server/package.json
is excluded by!**/*.json
packages/testtools/package.json
is excluded by!**/*.json
Files selected for processing (5)
- packages/ide/jetbrains/CHANGELOG.md (1 hunks)
- packages/ide/jetbrains/build.gradle.kts (1 hunks)
- packages/runtime/res/enhance.d.ts (1 hunks)
- packages/runtime/src/enhancements/policy/policy-utils.ts (2 hunks)
- tests/regression/tests/issue-1451.test.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/ide/jetbrains/build.gradle.kts
- tests/regression/tests/issue-1451.test.ts
Additional Context Used
LanguageTool (3)
packages/ide/jetbrains/CHANGELOG.md (3)
Near line 13: Possible typo: you repeated a word
Context: ...d - ZenStack V2 release! ## 1.11.0 ### Added - Added support to complex usage of@@index
a...
Near line 14: The preposition “for” seems more likely in this position than the preposition “to”.
Context: ...e! ## 1.11.0 ### Added - Added support to complex usage of@@index
attribute li...
Near line 15: Possible typo: you repeated a word
Context: ...raw("gin_trgm_ops"))], type: Gin)`. ### Fixed - Fixed several ZModel validation issues relate...
Additional comments not posted (2)
packages/runtime/res/enhance.d.ts (1)
1-1
: LGTM! The addition ofauth
to the export statement is correct.packages/runtime/src/enhancements/policy/policy-utils.ts (1)
963-965
: The change to recurse into relation fields before injecting the current level is a good improvement to prevent infinite recursion. Ensure this logic is thoroughly tested.Please verify that this change has been thoroughly tested to ensure it prevents infinite recursion without introducing new issues.
No description provided.