Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate alignment pileups #132

Merged

Conversation

deliaBlue
Copy link
Collaborator

This PR closes #4 .

The changes in this PR are:

  • Add the script that generates the ASCII-style pileups
  • Add the workflow that generates the pileups (pileup.smk)
  • Add a new function in the common.smk to generate an empty BED file if not provided by the user
  • Add the new workflow and its output files in the main Snakefile
  • Add the pileups parameters in the config_template.yaml, config_schema.json and test/config.yaml files
  • Add the BED files with the regions of interest as a test input file
  • Document the new workflow in the main README, the configuration README and in the pipeline_documentation.md
  • Update the expected output and the rule graph

@deliaBlue deliaBlue added the enhancement New feature or request label Jan 24, 2024
@deliaBlue deliaBlue self-assigned this Jan 24, 2024
@deliaBlue deliaBlue linked an issue Jan 24, 2024 that may be closed by this pull request
@uniqueg uniqueg changed the title feat: optionally generate alignment pileups for selected regions feat: generate alignment pileups Jan 24, 2024
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few minor issues

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config/README.md Outdated Show resolved Hide resolved
config/config_schema.json Outdated Show resolved Hide resolved
config/config_template.yaml Outdated Show resolved Hide resolved
config/config_template.yaml Outdated Show resolved Hide resolved
pipeline_documentation.md Outdated Show resolved Hide resolved
scripts/ascii_alignment_pileup.R Outdated Show resolved Hide resolved
test/test_files/pileup_regions.bed Outdated Show resolved Hide resolved
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config/README.md Outdated Show resolved Hide resolved
config/config_schema.json Outdated Show resolved Hide resolved
config/config_schema.json Outdated Show resolved Hide resolved
config/config_template.yaml Outdated Show resolved Hide resolved
config/config_template.yaml Show resolved Hide resolved
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@deliaBlue deliaBlue merged commit b2f667e into dev Jan 29, 2024
8 checks passed
@deliaBlue deliaBlue deleted the 4-optionally-generate-alignment-pileups-for-selected-regions branch January 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally generate alignment pileups for selected regions
2 participants