Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical/gh 297 update metrics #569

Merged
merged 49 commits into from
Jan 20, 2020
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
f312bc5
Upgrade go-metrics to v0.3.0
adidanes Dec 2, 2019
f8e1d98
Update metrics naming and use labels for workers, tasks and executor …
adidanes Dec 3, 2019
b0c7edd
Doc improvements
adidanes Dec 4, 2019
b3ebeda
Update metrics naming and use labels for ssh connection pool
adidanes Dec 4, 2019
e64acd1
Update metrics naming and use labels for actions scheduling. Update doc.
adidanes Dec 6, 2019
6ca03ff
Update names and labels for rest api metrics
adidanes Dec 6, 2019
99e7f93
Some improvements
adidanes Dec 6, 2019
655f1f2
Merge develop branch to technical/GH-297-update-metrics
adidanes Dec 9, 2019
f8ce6f6
Merge develop branch to technical/GH-297-update-metrics
adidanes Dec 16, 2019
17f7442
Upgrade github.com/prometheus/client_golang to v1.1.0
adidanes Dec 16, 2019
efbced1
Update changelog
adidanes Dec 16, 2019
2d86ba7
Upgrade prometheus modules: client_golang to v1.2.1, and procfs to v0…
adidanes Dec 16, 2019
d7a382b
Sleep 2sec to give time to emitTasksMetrics in Dispatcher test
adidanes Dec 17, 2019
65136ab
Refactor code instrumenting workers and tasks
adidanes Dec 18, 2019
aa99e9c
Some improvement
adidanes Dec 18, 2019
d4abf8a
Merge develop into technical/GH-297-update-metrics
adidanes Dec 19, 2019
b4878f1
Do some metrics refactor
adidanes Dec 19, 2019
09dea17
Fix telemetry doc
adidanes Dec 19, 2019
4ef3583
Fix telemetry doc
adidanes Dec 19, 2019
9da8df6
Add some tests
adidanes Dec 20, 2019
f66e99b
Fix test
adidanes Dec 20, 2019
a588aff
Fix telemetry doc
adidanes Dec 20, 2019
4a99c68
Fix telemetry doc
adidanes Dec 20, 2019
0470227
Fix telemetry doc
adidanes Jan 6, 2020
468df36
Fixed typo
laurentganne Jan 6, 2020
472f9bc
Fix telemetry doc - introduction section
adidanes Jan 6, 2020
6483580
Fix telemetry doc - merge typo fix
adidanes Jan 6, 2020
9c808fb
Fix telemetry doc - dump section fix
adidanes Jan 6, 2020
51fa739
Add status label only if a status were set in the header
adidanes Jan 6, 2020
ae9ca98
Improve executor metrics name
adidanes Jan 7, 2020
0c3a9a4
Compact code
adidanes Jan 7, 2020
df18e4a
Waiting duration is now measured for taskExecutions
adidanes Jan 8, 2020
28ffb2b
Fix telemetry doc
adidanes Jan 9, 2020
a349451
merged develop in technical/GH-297-update-metrics
adidanes Jan 13, 2020
378c887
Replace nbWaiting for tasks by nbWaiting for taskExecutions. No more …
adidanes Jan 14, 2020
d828a6f
Fix taskExecution metrics collection and naming
adidanes Jan 14, 2020
e7816e2
Use a constant instead of duplicating literal
adidanes Jan 14, 2020
e92e736
Fix telemetry doc
adidanes Jan 14, 2020
97edf6e
comment and unxeport constant
adidanes Jan 14, 2020
0d6780a
Clean-up unused code
adidanes Jan 14, 2020
784b86c
Fix constant name
adidanes Jan 15, 2020
0254a1e
Add unit test
adidanes Jan 15, 2020
ca16359
Fix metrics test
adidanes Jan 15, 2020
26b310d
Extend unit test
adidanes Jan 15, 2020
2da033a
Un-comment tests
adidanes Jan 15, 2020
83c75a5
Merge develop to technical/GH-297-update-metrics
adidanes Jan 15, 2020
a93fa42
Fix telemetry doc
adidanes Jan 16, 2020
0246706
Fis changelog just to check build ok
adidanes Jan 17, 2020
96e86e8
Mege develop to technical/GH-297-update-metrics
adidanes Jan 20, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

## UNRELEASED

### BREAKING CHANGES

#### Changes in Yorc metric namespace

In order to improve the observability of Yorc execution, the exposed metrics' names were modified.
Now labels are used which allow to provide metric trees ([GH-297](https://github.com/ystia/yorc/issues/297))

### ENHANCEMENTS

* Should be able to bootstrap Yorc on OpenStack with Identity API v3 ([GH-575](https://github.com/ystia/yorc/issues/575))
Expand All @@ -20,7 +27,7 @@

### BREAKING CHANGES

#### Changes on the REST API
#### Changes in the REST API

##### Deployment updates

Expand Down
207 changes: 135 additions & 72 deletions doc/telemetry.rst

Large diffs are not rendered by default.

102 changes: 45 additions & 57 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,98 +3,86 @@ module github.com/ystia/yorc/v4
// Makefile should also be updated when changing module major version (for injected variables)

require (
github.com/Bowery/prompt v0.0.0-20190419144237-972d0ceb96f5 // indirect
github.com/Masterminds/goutils v1.1.0 // indirect
github.com/Masterminds/semver v1.4.2 // indirect
github.com/Masterminds/sprig v2.20.0+incompatible // indirect
github.com/Azure/go-ansiterm v0.0.0-20170929234023-d6e3b3328b78 // indirect
github.com/Microsoft/go-winio v0.4.14 // indirect
github.com/Netflix/go-expect v0.0.0-20190729225929-0e00d9168667
github.com/Sirupsen/logrus v0.0.0-00010101000000-000000000000 // indirect
github.com/Nvveen/Gotty v0.0.0-20120604004816-cd527374f1e5 // indirect
github.com/SAP/go-hdb v0.14.1 // indirect
github.com/SermoDigital/jose v0.9.1 // indirect
github.com/abice/go-enum v0.1.4
github.com/alecthomas/participle v0.3.0
github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da
github.com/armon/go-metrics v0.3.0
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a // indirect
github.com/blang/semver v3.5.1+incompatible
github.com/bradleyjkemp/cupaloy v2.3.0+incompatible // indirect
github.com/cenkalti/backoff v2.2.1+incompatible // indirect
github.com/cheggaaa/pb/v3 v3.0.3
github.com/docker/distribution v2.7.1+incompatible // indirect
github.com/containerd/continuity v0.0.0-20191214063359-1097c8bae83b // indirect
github.com/denisenkom/go-mssqldb v0.0.0-20191128021309-1d7a30a10f73 // indirect
github.com/docker/docker v0.0.0-20170504205632-89658bed64c2
github.com/docker/go-connections v0.4.0 // indirect
github.com/docker/go-units v0.4.0 // indirect
github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7 // indirect
github.com/dustin/go-humanize v0.0.0-20160623014021-fef948f2d241
github.com/duosecurity/duo_api_golang v0.0.0-20190308151101-6c680f768e74 // indirect
github.com/dustin/go-humanize v0.0.0-20171111073723-bb3d318650d4
github.com/fatih/color v1.7.0
github.com/fatih/structs v1.1.0 // indirect
github.com/fsnotify/fsnotify v1.4.7
github.com/ghodss/yaml v1.0.0 // indirect
github.com/gogo/protobuf v1.2.1 // indirect
github.com/golang/snappy v0.0.1 // indirect
github.com/go-sql-driver/mysql v1.4.1 // indirect
github.com/gocql/gocql v0.0.0-20191126110522-1982a06ad6b9 // indirect
github.com/google/addlicense v0.0.0-20190107131845-2e5cf00261bf
github.com/google/gofuzz v1.0.0 // indirect
github.com/google/go-github v17.0.0+incompatible // indirect
github.com/google/go-querystring v1.0.0 // indirect
github.com/google/uuid v1.1.1
github.com/googleapis/gnostic v0.3.0 // indirect
github.com/gotestyourself/gotestyourself v2.2.0+incompatible // indirect
github.com/goware/urlx v0.3.1
github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 // indirect
github.com/hashicorp/consul v1.2.3
github.com/hashicorp/go-cleanhttp v0.5.1
github.com/hashicorp/go-hclog v0.8.0
github.com/hashicorp/go-immutable-radix v1.1.0 // indirect
github.com/hashicorp/go-memdb v1.0.4 // indirect
github.com/hashicorp/go-multierror v1.0.0
github.com/hashicorp/go-plugin v1.0.0
github.com/hashicorp/go-rootcerts v1.0.0
github.com/hashicorp/hcl v1.0.0 // indirect
github.com/hashicorp/serf v0.8.3 // indirect
github.com/hashicorp/vault v0.9.0
github.com/hinshun/vt10x v0.0.0-20180809195222-d55458df857c
github.com/huandu/xstrings v1.2.0 // indirect
github.com/imdario/mergo v0.3.7 // indirect
github.com/jefferai/jsonx v1.0.1 // indirect
github.com/julienschmidt/httprouter v1.2.0
github.com/justinas/alice v0.0.0-20160512134231-052b8b6c18ed
github.com/kardianos/osext v0.0.0-20190222173326-2bc1f35cddc0 // indirect
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
github.com/kr/pty v1.1.8 // indirect
github.com/labstack/gommon v0.2.9 // indirect
github.com/magiconair/properties v1.8.1 // indirect
github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect
github.com/mitchellh/go-homedir v1.0.0
github.com/keybase/go-crypto v0.0.0-20190828182435-a05457805304 // indirect
github.com/lib/pq v1.2.0 // indirect
github.com/mgutz/logxi v0.0.0-20161027140823-aebf8a7d67ab // indirect
github.com/mitchellh/copystructure v1.0.0 // indirect
github.com/mitchellh/go-homedir v1.1.0
github.com/mitchellh/mapstructure v1.1.2
github.com/mkideal/cli v0.0.3 // indirect
github.com/mkideal/pkg v0.0.0-20170503154153-3e188c9e7ecc // indirect
github.com/mitchellh/reflectwalk v1.0.1 // indirect
github.com/moby/moby v0.0.0-20170504205632-89658bed64c2
github.com/opencontainers/go-digest v1.0.0-rc1 // indirect
github.com/pelletier/go-toml v1.4.0 // indirect
github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
github.com/pkg/errors v0.8.0
github.com/prometheus/client_golang v1.0.0
github.com/prometheus/common v0.6.0 // indirect
github.com/prometheus/procfs v0.0.3 // indirect
github.com/opencontainers/image-spec v1.0.1 // indirect
github.com/opencontainers/runc v0.1.1 // indirect
github.com/ory/dockertest v3.3.5+incompatible // indirect
github.com/patrickmn/go-cache v2.1.0+incompatible // indirect
github.com/pkg/errors v0.8.1
github.com/prometheus/client_golang v1.2.1
github.com/prometheus/procfs v0.0.8 // indirect
github.com/ryanuber/go-glob v1.0.0 // indirect
github.com/satori/go.uuid v1.0.0
github.com/sethgrid/pester v0.0.0-20190127155807-68a33a018ad0 // indirect
github.com/spf13/afero v1.2.2 // indirect
github.com/spf13/cast v1.2.0
github.com/spf13/cobra v0.0.3
github.com/spf13/jwalterweatherman v1.1.0 // indirect
github.com/spf13/pflag v1.0.3 // indirect
github.com/spf13/viper v1.0.2
github.com/spf13/cast v1.3.0
github.com/spf13/cobra v0.0.5
github.com/spf13/viper v1.3.2
github.com/stevedomin/termtable v0.0.0-20150929082024-09d29f3fd628
github.com/stretchr/testify v1.3.0
github.com/stretchr/testify v1.4.0
github.com/tmc/dot v0.0.0-20180926222610-6d252d5ff882
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
golang.org/x/exp v0.0.0-20190627132806-fd42eb6b336f // indirect
github.com/ystia/tdt2go v0.2.0 // indirect
golang.org/x/crypto v0.0.0-20190325154230-a5d413f7728c
golang.org/x/net v0.0.0-20190613194153-d28f0bde5980
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45 // indirect
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4 // indirect
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
gopkg.in/AlecAivazis/survey.v1 v1.6.3
gopkg.in/cookieo9/resources-go.v2 v2.0.0-20150225115733-d27c04069d0d
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/yaml.v2 v2.2.2
gotest.tools v2.2.0+incompatible
gopkg.in/mgo.v2 v2.0.0-20190816093944-a6b53ec6cb22 // indirect
gopkg.in/ory-am/dockertest.v3 v3.3.5 // indirect
gopkg.in/yaml.v2 v2.2.4
k8s.io/api v0.0.0-20180628040859-072894a440bd
k8s.io/apimachinery v0.0.0-20180621070125-103fd098999d
k8s.io/client-go v8.0.0+incompatible
k8s.io/kube-openapi v0.0.0-20190709113604-33be087ad058 // indirect
vbom.ml/util v0.0.0-20160121211510-db5cfe13f5cc
)

// Due to this capital letter thing we have troubles and we have to replace it explicitly
replace github.com/Sirupsen/logrus => github.com/sirupsen/logrus v1.4.2
replace github.com/Sirupsen/logrus => github.com/sirupsen/logrus v1.4.1

go 1.13
Loading