Technical/gh 297 update metrics #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0.8, common to v0.7.0
laurentganne
reviewed
Jan 6, 2020
laurentganne
reviewed
Jan 6, 2020
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
helper/sshutil/session_pool.go
Outdated
| @@ -33,15 +33,17 @@ type pool struct { | |||
| mu sync.Mutex | |||
| } | |||
|
|
|||
| // Open starts a new SSH session on the given server, reusing | |||
| const SSH_CONNECTION_POOL = "ssh-connections-pool" | |||
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
|
Code Climate has analyzed commit a93fa42 and detected 0 issues on this pull request. View more on Code Climate. |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Description of the change
What I did
Upgrade armon/go-metrics to v0.30.
Redefine Yorc metrics names. Also use labels.
Update Yorc Telemetry chapter in Yorc documentation.
How I did it
In case of metrics that are identified by a name + some labels, I replaced the previousely called go-metrics function calls by the their variant that supports labels.
For example :
metrics.IncrCounter([]string{"name-part1", "name-part2", "status"}), 1)
replaces by
metrics.IncrCounterWithLabels(([]string{"name-part1", "name-part2"}), 1, lablels)
where
labels contain a label with Name = "status" and Value = getStatus()
How to verify it
Yorc telemetry config:
"telemetry": { "service_name": "myyorc", "disable_hostname": true, "disable_go_runtime_metrics": true, "expose_prometheus_endpoint": true }Deploy an application.
Check for metrcis on Yorc endpoint:
$ curl --noproxy '*' -v -H "Content-Type: application/json" "http://localhost:8800/metricsExample of metrics:
myyorc_http_duration_sum{method="GET",path="metrics"} 222.54512375593185
myyorc_http_duration_count{method="GET",path="metrics"} 68
myyorc_http_total{method="GET",path="deployments",status="0"} 1
Install and start Prometheus with scrape config:
scrape_configs section in prometheus.yml config file:
static_configs:
Check for metrcis on endpoint exposed for Prometheus:
$ curl --noproxy '*' -v -H "Content-Type: application/json" "http://localhost:9090/metricsor execute a query in Prometheus console, for example:
myyorc_http_totalDescription for the changelog
Applicable Issues
#297
#507