digest: Add AsRef<str> #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conceptually `Digest()` is just a parsed string wrapper. Many cases want to get access to the full value without allocating, and the introduction of the type was a regression from that point of view in 0.7. Luckily, we can change our internals in such a way that it's safe to add the impl. Do that by holding onto the full value, with a duplicate small boxed str for the algorithm only in the degenerate case that it's an unknown type. If we had this it would have made containers/bootc#800 less likely. Signed-off-by: Colin Walters <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
===========================================
+ Coverage 26.61% 70.77% +44.15%
===========================================
Files 24 26 +2
Lines 2788 3168 +380
Branches 1516 1673 +157
===========================================
+ Hits 742 2242 +1500
+ Misses 948 926 -22
+ Partials 1098 0 -1098 |
saschagrunert
approved these changes
Oct 7, 2024
utam0k
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually
Digest()is just a parsed string wrapper. Many cases want to get access to the full value without allocating, and the introduction of the type was a regression from that point of view in 0.7.Luckily, we can change our internals in such a way that it's safe to add the impl. Do that by holding onto the full value, with a duplicate small boxed str for the algorithm only in the degenerate case that it's an unknown type.
If we had this it would have made containers/bootc#800 less likely.
What type of PR is this?
/kind feature
What this PR does / why we need it:
See commit message
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?