-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootc status failed with error Reading deployment metadata: Missing base image ref ostree/container/blob/e05a2
#800
Comments
Yes I saw this on one machine too, it's really concerning. We may have broken the semantics for how we write refs as part of the upgrade in ostreedev/ostree-rs-ext#663 |
Conceptually `Digest()` is just a parsed string wrapper. Many cases want to get access to the full value without allocating, and the introduction of the type was a regression from that point of view in 0.7. Luckily, we can change our internals in such a way that it's safe to add the impl. Do that by holding onto the full value, with a duplicate small boxed str for the algorithm only in the degenerate case that it's an unknown type. If we had this it would have made containers/bootc#800 less likely. Signed-off-by: Colin Walters <[email protected]>
Should be fixed by #804 - thanks for the report. |
Verified on |
To explain the reason for this (it's important) - it's because the way Anaconda works today we rely on the version of the ostree-container code which is embedded in the ISO (ref rhinstaller/anaconda#5197 ). So we have version skew. But we really need to test the version-skew case in general, i.e. we want an "upgrade from stable" test that needs to gate PRs on this repo by default probably. |
Ack. It's in my list. The test flow would be start vm from fedora/cs-bootc image, and upgrade bootc with dnf upgrade (after bootc usr-overlay), then try bootc status. Adding this test into |
Conceptually `Digest()` is just a parsed string wrapper. Many cases want to get access to the full value without allocating, and the introduction of the type was a regression from that point of view in 0.7. Luckily, we can change our internals in such a way that it's safe to add the impl. Do that by holding onto the full value, with a duplicate small boxed str for the algorithm only in the degenerate case that it's an unknown type. If we had this it would have made containers/bootc#800 less likely. Signed-off-by: Colin Walters <[email protected]>
Hi @cgwalters, do you mean the |
Yep! |
Test comes from issue containers#800 Both rpm-ostree and bootc bump ostree-rs-ext. This test is to avoid version-skew issue Signed-off-by: Xiaofeng Wang <[email protected]>
This issue is for
anaconda
installation only (bib anaconda-iso included),bootc install
does not have this issue. Test result: https://gitlab.com/redhat/rhel/bifrost/tests/bootc-image/-/issues/219Deploy bootc image with anaconda kickstart and boot the system. System can be booted without error. Check ostree status with
rpm-ostree
successful. But check withbootc status
failed.bootc-202409192026.g85b2ca5256-1.el9.x86_64
.bootc-202409191923.geea3996f8f-1.el9.x86_64
does not have this issue.eea3996f8f
to85b2ca5256
. The a8737d9 might be the root case.The text was updated successfully, but these errors were encountered: