Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DMLQueryBuilder #275

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 19, 2023

Related with yiisoft/db#746

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Aug 19, 2023

PR Summary

  • Updates in DMLQueryBuilder.php
    This file received several adjustments to enhance its functionality. New arrays for handling created and inserted columns were added which will better manage the data in the columns during creation and insertion process. The condition to check database type was also updated to improve code accuracy. Lastly, a modification was made to the INSERT INTO query, enabling a more efficient way to insert data into the database.

  • Changes within CommandProvider.php
    One parameter value was adjusted in this file. This modification is meant to align the input value with the requirements of the function it's tied to, ensuring a correct and expected behavior of the code.

  • Enhancements in QueryBuilderProvider.php
    An additional test case was introduced to assess a different query situation. This will not only extend the coverage of our tests, it will help to ensure a broader range of scenarios are handled properly by the system.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1be5ddb) 98.56% compared to head (7274c8a) 97.72%.

❗ Current head 7274c8a differs from pull request most recent head 5c91770. Consider uploading reports for the commit 5c91770 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #275      +/-   ##
============================================
- Coverage     98.56%   97.72%   -0.84%     
  Complexity      218      218              
============================================
  Files            15       15              
  Lines           626      616      -10     
============================================
- Hits            617      602      -15     
- Misses            9       14       +5     
Files Coverage Δ
src/DMLQueryBuilder.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 19, 2023 11:05
Tigrov added a commit to Tigrov/db-mssql that referenced this pull request Aug 20, 2023
@Tigrov Tigrov mentioned this pull request Aug 20, 2023
Tigrov added a commit that referenced this pull request Aug 20, 2023
src/DMLQueryBuilder.php Show resolved Hide resolved
@Tigrov Tigrov merged commit 997ae8b into yiisoft:master Nov 1, 2023
14 of 15 checks passed
@Tigrov Tigrov deleted the refactor_dml_query_builder branch November 1, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants