Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm issue #275 #276

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Fix psalm issue #275 #276

merged 1 commit into from
Aug 20, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 20, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #275

@what-the-diff
Copy link

what-the-diff bot commented Aug 20, 2023

PR Summary

  • Modification in Command.php file
    The file Command.php has seen a number of changes in this pull request. Specifically, certain import elements and argument type hints have been altered or removed. These include:

    • Removed import: The import for Yiisoft\Db\Driver\Pdo\PdoConnectionInterface has been taken away in line 9. This means the pull request no longer requires this particular library to function.
    • Modified method internalExecute(string|null $rawSql): The changes in line 43 end up transforming how the internalExecute() method works with the removal of the argument type hint for $db.
    • Modified code block: In line 45, the PdoConnectionInterface $db argument has been replaced with an empty parameter list within the $this->db->transaction( code block. Again, this change adjusts the function of this code and its relationship to other parts of the program.

Please note that these modifications can affect how this file interacts with other parts of your software, especially where it involves the mentioned elements.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9747d60) 97.76% compared to head (edbe075) 97.76%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #276   +/-   ##
=========================================
  Coverage     97.76%   97.76%           
  Complexity      221      221           
=========================================
  Files            15       15           
  Lines           627      627           
=========================================
  Hits            613      613           
  Misses           14       14           
Files Changed Coverage Δ
src/Command.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 20, 2023 02:56
@Tigrov Tigrov merged commit 2538828 into yiisoft:master Aug 20, 2023
@Tigrov Tigrov deleted the fix_psalm_issue branch August 21, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant