Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting value for an attribute when AR class has get method for the attribute #274

Merged
merged 3 commits into from
Dec 16, 2023

Change `$this->name` to `$this->getAttribute('name')`

4a65d01
Select commit
Loading
Failed to load commit list.
Merged

Fix setting value for an attribute when AR class has get method for the attribute #274

Change `$this->name` to `$this->getAttribute('name')`
4a65d01
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 16, 2023 in 1s

87.76% (+0.00%) compared to 41c6691

View this Pull Request on Codecov

87.76% (+0.00%) compared to 41c6691

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c6691) 87.75% compared to head (4a65d01) 87.76%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #274   +/-   ##
=========================================
  Coverage     87.75%   87.76%           
  Complexity      598      598           
=========================================
  Files             7        7           
  Lines          1331     1332    +1     
=========================================
+ Hits           1168     1169    +1     
  Misses          163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov