Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting value for an attribute when AR class has get method for the attribute #274

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 13, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c6691) 87.75% compared to head (4a65d01) 87.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #274   +/-   ##
=========================================
  Coverage     87.75%   87.76%           
  Complexity      598      598           
=========================================
  Files             7        7           
  Lines          1331     1332    +1     
=========================================
+ Hits           1168     1169    +1     
  Misses          163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 13, 2023

PR Summary

  • Enhanced Stability in Base ActiveRecord Trait
    The change in the BaseActiveRecordTrait file provides better handling of your data. Specifically, we added a return statement to the __set method. This simply makes sure that any new information you provide for a data record gets stored properly.

  • Improvements in Customer Data Handling
    We made several adjustments to how we handle customer data in the Customer.php file:

    • New Method to Retrieve Customer Name: A new getName function was added. This gives you an easy way to access the names of your customers directly.

    • Simplified Table Identification: The getTableName method was modified. Now it always returns the string 'customer'. It's an internal adjustment to make our code more efficient.

    • Refined Customer Profiles Retrieval Process: The getProfile method was tweaked in a way it now returns an ActiveQuery object. This change enhances the way you get a customer's profile information, making it more streamlined and reliable.

These changes continue our commitment to improving the software's user-friendliness and reliability.

@samdark samdark added the type:bug Bug label Dec 13, 2023
@Tigrov Tigrov merged commit cdcca08 into master Dec 16, 2023
51 of 53 checks passed
@Tigrov Tigrov deleted the fix-set-value-when-ar-has-get-method branch December 16, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants