Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL-272] Refactor Reactions UI with re-route #96

Merged
merged 26 commits into from
Jan 14, 2025
Merged

[SQL-272] Refactor Reactions UI with re-route #96

merged 26 commits into from
Jan 14, 2025

Conversation

kelvinqian00
Copy link
Contributor

@kelvinqian00 kelvinqian00 commented Nov 26, 2024 •
edited
Loading

  • Add three new routes using re-route: /reactions/new, /reactions/:id/view, and /reactions/:id/edit, while restricting /reactions just to the Reactions table
  • Refactor Reactions UI so that focus, edit, and new components are separate instead of complected

@kelvinqian00
Replace reaction-view with mode-specific components
35cc206
@kelvinqian00
Separate action button bars
ae5efed
@kelvinqian00
Add sections
82533df
@kelvinqian00
Refactor ruleset-view
af11eae
@kelvinqian00
Refactor render-conditions
28770e6
@kelvinqian00
Refactor render-or-edit-condition-name
ba405d2
@kelvinqian00
Refactor render-clause
4210958
@kelvinqian00
Refactor path, op, val, and ref components
caa8b7c
@kelvinqian00
Refactor render-identity-paths
9c2a498
@kelvinqian00
Refactor render-view-or-edit-template
9969f5d
@kelvinqian00
Rename some components
57d26ea
@kelvinqian00
Refactor out reaction-ruleset-view
fb87a7e
@kelvinqian00
Remove redundant ruleset-new components
36a7215
@kelvinqian00
Rename rest of render- components
7b3e827
@kelvinqian00
Even more sectioning
e02bfca
@kelvinqian00
Properly avoid calling local-display on nils
b950816
@kelvinqian00
Add new reactions routes + views
dc61539
@kelvinqian00
Use new reaction routes
db68367
@kelvinqian00
Slight reformatting of route map
2ac715c
@kelvinqian00
Refactor cancel-edit into clear-edit
df262dd
@kelvinqian00
Only dispatch unset-focus when leaving the focus page
037ec2a
@kelvinqian00
Delete back-to-list effect
2dd5ff5
@kelvinqian00
Delete reaction mode sub
3ad18d0
@kelvinqian00
Add edit-error? sub
c327279
@kelvinqian00 kelvinqian00 changed the title [SQL-272] Refactor reactions for re-route [SQL-272] Refactor Reactions UI with re-route Nov 26, 2024
@kelvinqian00 kelvinqian00 marked this pull request as ready for review November 26, 2024 21:49
Base automatically changed from re-route-impl-2 to admin-jwt-renew-reroute-epic January 14, 2025 20:01
@kelvinqian00 kelvinqian00 merged commit c1755c1 into admin-jwt-renew-reroute-epic Jan 14, 2025
4 checks passed
@kelvinqian00 kelvinqian00 deleted the re-route-impl-reactions branch January 14, 2025 20:13
@kelvinqian00 kelvinqian00 mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milt milt milt approved these changes

@cliffcaseyyet cliffcaseyyet Awaiting requested review from cliffcaseyyet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvinqian00 @milt