Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL-264] JWT Renewal + re-route implementation #99

Open
wants to merge 100 commits into
base: main
Choose a base branch
from
Open

[SQL-264] JWT Renewal + re-route implementation #99

wants to merge 100 commits into from

Conversation

kelvinqian00
Copy link
Contributor

@kelvinqian00 kelvinqian00 commented Jan 14, 2025 •
edited
Loading

Feature branch for implementing JWT logout and renewal + refactoring the frontend to use re-route.

Main Changes:

  • Implement JWT renewal, storing config vars from BE and renewing using the :login/try-renew effect handler
  • Apply logout to regular login mode via the :logout/logout effect handler (while keeping OIDC and proxy JWT logouts the same)
  • Use re-route to create the following routes:
    • /credentials (same as /)
    • /accounts
    • /accounts/password
    • /browser (statement browser)
    • /data-management (actor delete)
    • /status
    • /reactions
    • /reactions/new
    • /reactions/:id/view
    • /reactions/:id/edit
    • /not-found
  • Dynamically create resource routes (e.g. for images) in ClojureScript (via subscriptions) and HTML (via Selmer templates)

Pull Requests:

@kelvinqian00
Use logout endpoint in logout handler
92a7bf0
@kelvinqian00
Add session clear-token and clear-username handlers
3bdbed0
@kelvinqian00
Use reg-global-interceptor instead of manually adding
7deaf77
@kelvinqian00
Add new-account to db
257a5fe
@kelvinqian00
Instrument all effects with interaction interceptor
ac32bf2
@kelvinqian00
Add last-interaction-time to db
5348535
@kelvinqian00
Add docstring to interaction-interceptor
f6967de
@kelvinqian00
Add timeout and renewal effects
abbb760
@kelvinqian00
Replace jwt-exp-time with jwt-refresh-interval and jwt-interaction-wi…
80a3b60 
…ndow
@kelvinqian00
Dispatch renewal event on login, not init
48688e3
@kelvinqian00
Don't renew JWT if logged out
180f026
@kelvinqian00
Remove printlns
1489756
@kelvinqian00
Log out upon renewal failure
472640c
@kelvinqian00
Call admin/verify before loading xapi in stmt browser
51bff1f
@kelvinqian00
Add verify-login handler to check login upon refresh
0b0f7cb
@kelvinqian00
Update comments
0c8bfbb
@kelvinqian00
Remove anomalous comment
013c0e4
@kelvinqian00
Use clear-token event in server error
793e3f3
@kelvinqian00
Extract out placeholder token
fb62591
@kelvinqian00
No calls to verify endpoint in OIDC auth
a95f482
@kelvinqian00
Resection and rename login/logout handlers
93fe314
@kelvinqian00
Update server-error for 401s and use it more
406d577
@kelvinqian00
Add re-route dep
ea2b725
@kelvinqian00
Create not-found view
48033fe
@kelvinqian00
Add routes namespace
69451f5
@kelvinqian00
Init routes in handler
b3acced
@kelvinqian00
Fix route controllers
d27e5c5
@kelvinqian00
Move router init to core ns
db56bb1
@kelvinqian00
Add home page
5f6773c
@kelvinqian00
Use route-view sub in main view
e778b5f
kelvinqian00 and others added 27 commits November 25, 2024 17:38
@kelvinqian00
Refactor path, op, val, and ref components
caa8b7c
@kelvinqian00
Refactor render-identity-paths
9c2a498
@kelvinqian00
Refactor render-view-or-edit-template
9969f5d
@kelvinqian00
Rename some components
57d26ea
@kelvinqian00
Refactor out reaction-ruleset-view
fb87a7e
@kelvinqian00
Remove redundant ruleset-new components
36a7215
@kelvinqian00
Rename rest of render- components
7b3e827
@kelvinqian00
Even more sectioning
e02bfca
@kelvinqian00
Properly avoid calling local-display on nils
b950816
@kelvinqian00
Add new reactions routes + views
dc61539
@kelvinqian00
Use new reaction routes
db68367
@kelvinqian00
Slight reformatting of route map
2ac715c
@kelvinqian00
Refactor cancel-edit into clear-edit
df262dd
@kelvinqian00
Only dispatch unset-focus when leaving the focus page
037ec2a
@kelvinqian00
Delete back-to-list effect
2dd5ff5
@kelvinqian00
Delete reaction mode sub
3ad18d0
@kelvinqian00
Add edit-error? sub
c327279
@kelvinqian00
Add some TODOs for edit saving
626f5c4
@kelvinqian00
Merge pull request #91 from yetanalytics/jwt-enhancements-2
311d3f7 
[SQL-264] JWT enhancements
@kelvinqian00
Merge pull request #93 from yetanalytics/re-route-path-updates
10dd806 
[SQL-271] SPA Path Updates to prepare for re-route
@kelvinqian00
Merge branch 'admin-jwt-renew-reroute-epic' into re-route-impl-2
79a43c1
@kelvinqian00
Remove stray println
37aaa8e
@kelvinqian00
Fix compiler warnings caused by merge commit
f1eeaec
@kelvinqian00
Slightly refactor routes in set-env
f1f4a44
@kelvinqian00
Merge pull request #94 from yetanalytics/re-route-impl-2
606edee 
[SQL-271] Implement re-route routing
@kelvinqian00
Merge branch 'admin-jwt-renew-reroute-epic' into re-route-impl-reactions
eff8d2b
@kelvinqian00
Merge pull request #96 from yetanalytics/re-route-impl-reactions
c1755c1 
[SQL-272] Refactor Reactions UI with re-route
@kelvinqian00 kelvinqian00 marked this pull request as ready for review January 14, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milt milt Awaiting requested review from milt

@cliffcaseyyet cliffcaseyyet Awaiting requested review from cliffcaseyyet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kelvinqian00