warning: unused `core::result::Result` that must be used --> ublox-cellular/src/network.rs:210:9 | 210 | self.check_running_imsi(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 210 | let _ = self.check_running_imsi(); | +++++++

warning: this expression mutably borrows a mutable reference. Consider reborrowing --> ublox-cellular/src/services/data/mod.rs:538:27 | 538 | let network = &mut self.network; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: `-W clippy::mut-mut` implied by `-W clippy::pedantic`

warning: unneeded `return` statement --> ublox-cellular/src/services/data/mod.rs:661:13 | 661 | return Err(Error::SocketMemory); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 661 - return Err(Error::SocketMemory); 661 + Err(Error::SocketMemory) |

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/mod.rs:532:5 | 532 | pub fn handle_urc<F: FnOnce(Urc) -> bool>(&mut self, f: F) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/mod.rs:525:5 | 525 | / pub fn send_at<A, const LEN: usize>(&mut self, cmd: &A) -> Result<A::Response, Error> 526 | | where 527 | | A: atat::AtatCmd<LEN>, | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/mod.rs:203:5 | 203 | / pub fn try_new( 204 | | apn_info: &APNInfo, 205 | | network: &'a mut Network<C, CLK, TIMER_HZ>, 206 | | sockets: Option<&'a mut SocketSet<TIMER_HZ, N, L>>, 207 | | ) -> nb::Result<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: item name starts with its containing module's name --> ublox-cellular/src/services/data/mod.rs:188:12 | 188 | pub struct DataService<'a, C, CLK, const TIMER_HZ: u32, const N: usize, const L: usize> | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/mod.rs:148:5 | 148 | / pub fn data_service<'a>( 149 | | &'a mut self, 150 | | apn_info: &APNInfo, 151 | | ) -> nb::Result<DataService<'a, C, CLK, TIMER_HZ, N, L>, DeviceError> { | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: consider adding a `;` to the last statement for consistent formatting --> ublox-cellular/src/services/data/hex.rs:31:9 | 31 | hex[i] = val(hex[i * 2])? << 4 | val(hex[i * 2 + 1])? | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `hex[i] = val(hex[i * 2])? << 4 | val(hex[i * 2 + 1])?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: item name ends with its containing module's name --> ublox-cellular/src/services/data/hex.rs:24:8 | 24 | pub fn from_hex(hex: &mut [u8]) -> Result<&[u8], FromHexError> { | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/services/data/hex.rs:1:30 | 1 | #[derive(Debug, Clone, Copy, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: useless conversion to the same type: `ublox_sockets::Error` --> ublox-cellular/src/services/data/tcp_stack.rs:186:17 | 186 | Err(Error::Illegal.into()) | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Illegal` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-cellular/src/services/data/tcp_stack.rs:121:31 | 121 | if !self.is_connected(&socket)? { | ^^^^^^^ help: change this to: `socket` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

warning: useless conversion to the same type: `ublox_sockets::Error` --> ublox-cellular/src/services/data/tcp_stack.rs:110:17 | 110 | Err(Error::Illegal.into()) | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Illegal` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/ssl.rs:30:5 | 30 | / fn enable_ssl( 31 | | &mut self, 32 | | profile_id: SecurityProfileId, 33 | | server_hostname: &str, 34 | | use_sni: bool, 35 | | ) -> Result<(), Error>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/ssl.rs:23:5 | 23 | / fn import_private_key( 24 | | &mut self, 25 | | profile_id: SecurityProfileId, 26 | | name: &str, 27 | | private_key: &[u8], 28 | | password: Option<&str>, 29 | | ) -> Result<(), Error>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/ssl.rs:17:5 | 17 | / fn import_root_ca( 18 | | &mut self, 19 | | profile_id: SecurityProfileId, 20 | | name: &str, 21 | | root_ca: &[u8], 22 | | ) -> Result<(), Error>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/services/data/ssl.rs:11:5 | 11 | / fn import_certificate( 12 | | &mut self, 13 | | profile_id: SecurityProfileId, 14 | | name: &str, 15 | | certificate: &[u8], 16 | | ) -> Result<(), Error>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: usage of wildcard import --> ublox-cellular/src/services/data/ssl.rs:2:54 | 2 | use crate::command::device_data_security::{types::*, *}; | ^ help: try: `PrepareSecurityDataImport, SecurityProfileManager, SendSecurityDataImport` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/services/data/ssl.rs:2:44 | 2 | use crate::command::device_data_security::{types::*, *}; | ^^^^^^^^ help: try: `types::{CertificateValidationLevel, SecurityDataType, SecurityProfileOperation}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: unnecessary structure name repetition --> ublox-cellular/src/services/data/error.rs:35:9 | 35 | Error::Socket(e) | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/services/data/error.rs:28:18 | 28 | _ => Error::Network(e), | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/services/data/error.rs:27:41 | 27 | NetworkError::Generic(g) => Error::Generic(g), | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: variables can be used directly in the `format!` string --> ublox-cellular/src/services/data/dns.rs:21:9 | 21 | write!(&mut ip_str, "{}", ip_addr).map_err(|_| Error::BadLength)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic` help: change this to | 21 - write!(&mut ip_str, "{}", ip_addr).map_err(|_| Error::BadLength)?; 21 + write!(&mut ip_str, "{ip_addr}").map_err(|_| Error::BadLength)?; |

warning: unnecessary structure name repetition --> ublox-cellular/src/services/data/apn.rs:24:9 | 24 | APNInfo { | ^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: this method could have a `#[must_use]` attribute --> ublox-cellular/src/services/data/apn.rs:23:5 | 23 | pub fn new(apn: &str) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(apn: &str) -> Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate

warning: unnecessary structure name repetition --> ublox-cellular/src/services/data/apn.rs:11:9 | 11 | Apn::Automatic | ^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: this `impl` can be derived --> ublox-cellular/src/services/data/apn.rs:9:1 | 9 | / impl Default for Apn { 10 | | fn default() -> Self { 11 | | Apn::Automatic 12 | | } 13 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: remove the manual implementation... help: ...and instead derive it... | 4 + #[derive(Default)] 5 | pub enum Apn { | help: ...and mark the default variant | 6 ~ #[default] 7 ~ Automatic, |

warning: consider adding a `;` to the last statement for consistent formatting --> ublox-cellular/src/registration.rs:295:21 | 295 | self.check_imsi = true | ^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.check_imsi = true;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: consider adding a `;` to the last statement for consistent formatting --> ublox-cellular/src/registration.rs:288:21 | 288 | self.check_imsi = true | ^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.check_imsi = true;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: consider adding a `;` to the last statement for consistent formatting --> ublox-cellular/src/registration.rs:281:21 | 281 | self.check_imsi = true | ^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.check_imsi = true;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: item name starts with its containing module's name --> ublox-cellular/src/registration.rs:189:12 | 189 | pub struct RegistrationState<CLK, const TIMER_HZ: u32> | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:171:31 | 171 | RegType::Cereg => RadioAccessNetwork::Eutran, | ^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:170:31 | 170 | RegType::Cgreg => RadioAccessNetwork::Utran, | ^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:169:30 | 169 | RegType::Creg => RadioAccessNetwork::Geran, | ^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:168:33 | 168 | RegType::Unknown => RadioAccessNetwork::UnknownUnused, | ^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:160:43 | 160 | RadioAccessNetwork::Eutran => RegType::Cereg, | ^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:159:42 | 159 | RadioAccessNetwork::Utran => RegType::Cgreg, | ^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:158:42 | 158 | RadioAccessNetwork::Geran => RegType::Creg, | ^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/registration.rs:157:50 | 157 | RadioAccessNetwork::UnknownUnused => RegType::Unknown, | ^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: item name starts with its containing module's name --> ublox-cellular/src/registration.rs:128:12 | 128 | pub struct RegistrationParams { | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: this could be a `const fn` --> ublox-cellular/src/registration.rs:65:5 | 65 | / pub fn registered(&self) -> bool { 66 | | matches!(self.status, Status::Home | Status::Roaming) 67 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: this could be a `const fn` --> ublox-cellular/src/registration.rs:53:5 | 53 | / pub fn get_status(&self) -> Status { 54 | | self.status 55 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: this could be a `const fn` --> ublox-cellular/src/registration.rs:43:5 | 43 | / pub fn updated(&self) -> Option<TimerInstantU32<TIMER_HZ>> { 44 | | self.updated 45 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: this could be a `const fn` --> ublox-cellular/src/registration.rs:39:5 | 39 | / pub fn started(&self) -> Option<TimerInstantU32<TIMER_HZ>> { 40 | | self.started 41 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> ublox-cellular/src/power.rs:265:15 | 265 | while self | _______________^ 266 | | .network 267 | | .status 268 | | .timer 269 | | .now() 270 | | .checked_duration_since(start) 271 | | .and_then(|dur| Some(dur < timeout)) | |________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map = note: `-W clippy::bind-instead-of-map` implied by `-W clippy::all` help: try this | 265 ~ while self 266 + .network 267 + .status 268 + .timer 269 + .now() 270 + .checked_duration_since(start).map(|dur| dur < timeout) |

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/power.rs:238:5 | 238 | pub fn power_state(&mut self) -> Result<PowerState, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/power.rs:201:5 | 201 | pub fn hard_power_off(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/power.rs:183:5 | 183 | pub fn soft_power_off(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: unnecessary `!=` operation --> ublox-cellular/src/power.rs:147:9 | 147 | / if self.power_state()? != PowerState::On { 148 | | trace!("Powering modem on."); 149 | | if let Some(ref mut pwr) = self.config.pwr_pin { 150 | | // Apply Low pulse on PWR_ON for 50 microseconds to power on ... | 178 | | debug!("module is already on"); 179 | | } | |_________^ | = help: change to `==` and swap the blocks of the `if`/`else` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else = note: `-W clippy::if-not-else` implied by `-W clippy::pedantic`

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/power.rs:140:5 | 140 | pub fn power_on(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> ublox-cellular/src/power.rs:112:9 | 112 | / match self.config.rst_pin { 113 | | Some(ref mut rst) => { 114 | | // Apply Low pulse on RESET_N for 50 milliseconds to reset 115 | | rst.set_low().ok(); ... | 132 | | None => {} 133 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-W clippy::single-match` implied by `-W clippy::all` help: try this | 112 ~ if let Some(ref mut rst) = self.config.rst_pin { 113 + // Apply Low pulse on RESET_N for 50 milliseconds to reset 114 + rst.set_low().ok(); 115 + 116 + self.network 117 + .status 118 + .timer 119 + .start(50.millis()) 120 + .map_err(from_clock)?; 121 + nb::block!(self.network.status.timer.wait()).map_err(from_clock)?; 122 + 123 + rst.set_high().ok(); 124 + self.network 125 + .status 126 + .timer 127 + .start(5.secs()) 128 + .map_err(from_clock)?; 129 + nb::block!(self.network.status.timer.wait()).map_err(from_clock)?; 130 + } |

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/power.rs:110:5 | 110 | pub fn hard_reset(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: item in documentation is missing backticks --> ublox-cellular/src/power.rs:107:42 | 107 | /// Reset the module by driving it's RESET_N pin low for 50 ms | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 107 | /// Reset the module by driving it's `RESET_N` pin low for 50 ms | ~~~~~~~~~

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/power.rs:57:5 | 57 | pub fn factory_reset(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: item name starts with its containing module's name --> ublox-cellular/src/power.rs:23:10 | 23 | pub enum PowerState { | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: consider adding a `;` to the last statement for consistent formatting --> ublox-cellular/src/network.rs:476:13 | 476 | self.status.compare_and_set(reg_params, ts) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.status.compare_and_set(reg_params, ts);` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned = note: `-W clippy::semicolon-if-nothing-returned` implied by `-W clippy::pedantic`

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:427:17 | 427 | Urc::NetworkPDNDeactivate => { | ^------------------------ | | | _________________help: try merging the arm patterns: `Urc::NetworkPDNDeactivate | Urc::MobileStationPDNDeactivate` | | 428 | | warn!("Network PDN Deactivate URC!"); 429 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:430:17 | 430 | / Urc::MobileStationPDNDeactivate => { 431 | | warn!("ME PDN Deactivate URC!"); 432 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:424:17 | 424 | Urc::MobileStationDeactivate => { | ^--------------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDeactivate | Urc::MobileStationPDNDeactivate` | | 425 | | warn!("ME Deactivate URC!"); 426 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:430:17 | 430 | / Urc::MobileStationPDNDeactivate => { 431 | | warn!("ME PDN Deactivate URC!"); 432 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:421:17 | 421 | Urc::NetworkDeactivate => { | ^--------------------- | | | _________________help: try merging the arm patterns: `Urc::NetworkDeactivate | Urc::MobileStationPDNDeactivate` | | 422 | | warn!("Network Deactivate URC!"); 423 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:430:17 | 430 | / Urc::MobileStationPDNDeactivate => { 431 | | warn!("ME PDN Deactivate URC!"); 432 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:418:17 | 418 | Urc::MobileStationDetach => { | ^----------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDetach | Urc::MobileStationPDNDeactivate` | | 419 | | warn!("ME Detach URC!"); 420 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:430:17 | 430 | / Urc::MobileStationPDNDeactivate => { 431 | | warn!("ME PDN Deactivate URC!"); 432 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:430:17 | 430 | Urc::MobileStationPDNDeactivate => { | ^------------------------------ | | | _________________help: try merging the arm patterns: `Urc::MobileStationPDNDeactivate | Urc::NetworkDetach` | | 431 | | warn!("ME PDN Deactivate URC!"); 432 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:415:17 | 415 | / Urc::NetworkDetach => { 416 | | warn!("Network Detach URC!"); 417 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:424:17 | 424 | Urc::MobileStationDeactivate => { | ^--------------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDeactivate | Urc::NetworkPDNDeactivate` | | 425 | | warn!("ME Deactivate URC!"); 426 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:427:17 | 427 | / Urc::NetworkPDNDeactivate => { 428 | | warn!("Network PDN Deactivate URC!"); 429 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:421:17 | 421 | Urc::NetworkDeactivate => { | ^--------------------- | | | _________________help: try merging the arm patterns: `Urc::NetworkDeactivate | Urc::NetworkPDNDeactivate` | | 422 | | warn!("Network Deactivate URC!"); 423 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:427:17 | 427 | / Urc::NetworkPDNDeactivate => { 428 | | warn!("Network PDN Deactivate URC!"); 429 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:418:17 | 418 | Urc::MobileStationDetach => { | ^----------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDetach | Urc::NetworkPDNDeactivate` | | 419 | | warn!("ME Detach URC!"); 420 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:427:17 | 427 | / Urc::NetworkPDNDeactivate => { 428 | | warn!("Network PDN Deactivate URC!"); 429 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:427:17 | 427 | Urc::NetworkPDNDeactivate => { | ^------------------------ | | | _________________help: try merging the arm patterns: `Urc::NetworkPDNDeactivate | Urc::NetworkDetach` | | 428 | | warn!("Network PDN Deactivate URC!"); 429 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:415:17 | 415 | / Urc::NetworkDetach => { 416 | | warn!("Network Detach URC!"); 417 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:421:17 | 421 | Urc::NetworkDeactivate => { | ^--------------------- | | | _________________help: try merging the arm patterns: `Urc::NetworkDeactivate | Urc::MobileStationDeactivate` | | 422 | | warn!("Network Deactivate URC!"); 423 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:424:17 | 424 | / Urc::MobileStationDeactivate => { 425 | | warn!("ME Deactivate URC!"); 426 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:418:17 | 418 | Urc::MobileStationDetach => { | ^----------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDetach | Urc::MobileStationDeactivate` | | 419 | | warn!("ME Detach URC!"); 420 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:424:17 | 424 | / Urc::MobileStationDeactivate => { 425 | | warn!("ME Deactivate URC!"); 426 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:424:17 | 424 | Urc::MobileStationDeactivate => { | ^--------------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDeactivate | Urc::NetworkDetach` | | 425 | | warn!("ME Deactivate URC!"); 426 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:415:17 | 415 | / Urc::NetworkDetach => { 416 | | warn!("Network Detach URC!"); 417 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:418:17 | 418 | Urc::MobileStationDetach => { | ^----------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDetach | Urc::NetworkDeactivate` | | 419 | | warn!("ME Detach URC!"); 420 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:421:17 | 421 | / Urc::NetworkDeactivate => { 422 | | warn!("Network Deactivate URC!"); 423 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:421:17 | 421 | Urc::NetworkDeactivate => { | ^--------------------- | | | _________________help: try merging the arm patterns: `Urc::NetworkDeactivate | Urc::NetworkDetach` | | 422 | | warn!("Network Deactivate URC!"); 423 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:415:17 | 415 | / Urc::NetworkDetach => { 416 | | warn!("Network Detach URC!"); 417 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> ublox-cellular/src/network.rs:418:17 | 418 | Urc::MobileStationDetach => { | ^----------------------- | | | _________________help: try merging the arm patterns: `Urc::MobileStationDetach | Urc::NetworkDetach` | | 419 | | warn!("ME Detach URC!"); 420 | | } | |_________________^ | = help: or try changing either arm body note: other arm here --> ublox-cellular/src/network.rs:415:17 | 415 | / Urc::NetworkDetach => { 416 | | warn!("Network Detach URC!"); 417 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms = note: `-W clippy::match-same-arms` implied by `-W clippy::pedantic`

warning: this function's return value is unnecessary --> ublox-cellular/src/network.rs:388:5 | 388 | / pub fn update_registration(&mut self) -> Result<(), Error> { 389 | | let ts = self.status.timer.now(); 390 | | 391 | | self.send_internal(&GetExtendedErrorReport, false).ok(); ... | 405 | | Ok(()) 406 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps help: remove the return type... | 388 | pub fn update_registration(&mut self) -> Result<(), Error> { | ~~~~~~~~~~~~~~~~~ help: ...and then remove returned values | 405 - Ok(()) 405 + |

warning: this function's return value is unnecessary --> ublox-cellular/src/network.rs:192:5 | 192 | / pub fn reset_reg_time(&mut self) -> Result<(), Error> { 193 | | let now = self.status.timer.now(); 194 | | 195 | | self.status.reg_start_time.replace(now); 196 | | self.status.reg_check_time = self.status.reg_start_time; 197 | | Ok(()) 198 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps help: remove the return type... | 192 | pub fn reset_reg_time(&mut self) -> Result<(), Error> { | ~~~~~~~~~~~~~~~~~ help: ...and then remove returned values | 197 - Ok(()) 197 + |

warning: this function's return value is unnecessarily wrapped by `Result` --> ublox-cellular/src/network.rs:188:5 | 188 | / pub fn is_connected(&self) -> Result<bool, Error> { 189 | | Ok(matches!(self.status.conn_state, ConnectionState::Connected)) 190 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps help: remove `Result` from the return type... | 188 | pub fn is_connected(&self) -> bool { | ~~~~ help: ...and then change returning expressions | 189 | matches!(self.status.conn_state, ConnectionState::Connected) |

warning: this could be a `const fn` --> ublox-cellular/src/network.rs:188:5 | 188 | / pub fn is_connected(&self) -> Result<bool, Error> { 189 | | Ok(matches!(self.status.conn_state, ConnectionState::Connected)) 190 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: unnecessary structure name repetition --> ublox-cellular/src/network.rs:181:9 | 181 | Network { | ^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: redundant clone --> ublox-cellular/src/network.rs:150:22 | 150 | if !f(urc.clone()) { | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> ublox-cellular/src/network.rs:150:19 | 150 | if !f(urc.clone()) { | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `-W clippy::redundant-clone` implied by `-W clippy::nursery`

warning: this function's return value is unnecessary --> ublox-cellular/src/network.rs:145:5 | 145 | / pub fn handle_urc<F: FnOnce(Urc) -> bool>(&mut self, f: F) -> Result<(), Error> { 146 | | let mut a = self.urc_attempts; 147 | | let max = self.max_urc_attempts; 148 | | ... | 162 | | Ok(()) 163 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps help: remove the return type... | 145 | pub fn handle_urc<F: FnOnce(Urc) -> bool>(&mut self, f: F) -> Result<(), Error> { | ~~~~~~~~~~~~~~~~~ help: ...and then remove returned values | 162 - Ok(()) 162 + |

warning: this function's return value is unnecessary --> ublox-cellular/src/network.rs:67:5 | 67 | / pub fn reset(&mut self) -> Result<(), Error> { 68 | | warn!("atat reset"); 69 | | self.client.reset(); 70 | | Ok(()) 71 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps = note: `-W clippy::unnecessary-wraps` implied by `-W clippy::pedantic` help: remove the return type... | 67 | pub fn reset(&mut self) -> Result<(), Error> { | ~~~~~~~~~~~~~~~~~ help: ...and then remove returned values | 70 - Ok(()) 70 + |

warning: this could be a `const fn` --> ublox-cellular/src/network.rs:58:5 | 58 | / pub fn new(client: C, max_urc_attempts: u8) -> Self { 59 | | Self { 60 | | urc_attempts: 0, 61 | | consecutive_timeouts: 0, ... | 64 | | } 65 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: this argument is passed by value, but not consumed in the function body --> ublox-cellular/src/error.rs:57:30 | 57 | pub fn from_clock<E>(_error: E) -> Error { | ^ help: consider taking a reference instead: `&E` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value = note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`

warning: unnecessary structure name repetition --> ublox-cellular/src/error.rs:49:18 | 49 | _ => Error::Network(e), | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/error.rs:48:41 | 48 | NetworkError::Generic(g) => Error::Generic(g), | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/error.rs:39:18 | 39 | _ => Error::DataService(e), | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/error.rs:38:45 | 38 | DataServiceError::Network(g) => Error::Network(g), | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/error.rs:37:45 | 37 | DataServiceError::Generic(g) => Error::Generic(g), | ^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/error.rs:4:17 | 4 | #[derive(Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: item name ends with its containing module's name --> ublox-cellular/src/error.rs:6:10 | 6 | pub enum GenericError { | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:118:9 | 118 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: missing `#[must_use]` attribute on a method returning `Self` --> ublox-cellular/src/config.rs:117:5 | 117 | / pub fn with_flow_control(self) -> Self { 118 | | Config { 119 | | flow_control: true, 120 | | ..self 121 | | } 122 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:111:9 | 111 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: missing `#[must_use]` attribute on a method returning `Self` --> ublox-cellular/src/config.rs:108:5 | 108 | / pub fn baud_rate<B: Into<u32>>(self, baud_rate: B) -> Self { 109 | | // FIXME: Validate baudrates 110 | | 111 | | Config { ... | 114 | | } 115 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:102:9 | 102 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: missing `#[must_use]` attribute on a method returning `Self` --> ublox-cellular/src/config.rs:101:5 | 101 | / pub fn with_vint(self, vint_pin: VINT) -> Self { 102 | | Config { 103 | | vint_pin: Some(vint_pin), 104 | | ..self 105 | | } 106 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:95:9 | 95 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: missing `#[must_use]` attribute on a method returning `Self` --> ublox-cellular/src/config.rs:94:5 | 94 | / pub fn with_dtr(self, dtr_pin: DTR) -> Self { 95 | | Config { 96 | | dtr_pin: Some(dtr_pin), 97 | | ..self 98 | | } 99 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:88:9 | 88 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: missing `#[must_use]` attribute on a method returning `Self` --> ublox-cellular/src/config.rs:87:5 | 87 | / pub fn with_pwr(self, pwr_pin: PWR) -> Self { 88 | | Config { 89 | | pwr_pin: Some(pwr_pin), 90 | | ..self 91 | | } 92 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:81:9 | 81 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: missing `#[must_use]` attribute on a method returning `Self` --> ublox-cellular/src/config.rs:80:5 | 80 | / pub fn with_rst(self, rst_pin: RST) -> Self { 81 | | Config { 82 | | rst_pin: Some(rst_pin), 83 | | ..self 84 | | } 85 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use = note: `-W clippy::return-self-not-must-use` implied by `-W clippy::pedantic`

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:68:9 | 68 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: this method could have a `#[must_use]` attribute --> ublox-cellular/src/config.rs:67:5 | 67 | pub fn new(pin: &str) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(pin: &str) -> Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate

warning: unnecessary structure name repetition --> ublox-cellular/src/config.rs:47:9 | 47 | Config { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: usage of wildcard import --> ublox-cellular/src/command/system_features/mod.rs:11:5 | 11 | use types::*; | ^^^^^^^^ help: try: `types::{FSFactoryRestoreType, NVMFactoryRestoreType, PowerSavingMode, Seconds}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/system_features/mod.rs:10:5 | 10 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{FactoryConfiguration, PowerSavingControl}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/system_features/types.rs:51:23 | 51 | #[derive(Clone, Copy, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/system_features/types.rs:40:23 | 40 | #[derive(Clone, Copy, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/system_features/types.rs:36:17 | 36 | #[derive(Clone, PartialEq, AtatLen, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/system_features/types.rs:5:17 | 5 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/system_features/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::{FSFactoryRestoreType, NVMFactoryRestoreType, PowerSavingMode, Seconds}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/sms/mod.rs:9:5 | 9 | use types::*; | ^^^^^^^^ help: try: `types::MessageWaitingMode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/sms/types.rs:25:24 | 25 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/sms/types.rs:5:24 | 5 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:398:67 | 398 | /// - **LARA-R2 / TOBY-R2 / SARA-U2 / LISA-U2 / SARA-G3** - When <auth_type>=3 | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 398 | /// - **LARA-R2 / TOBY-R2 / SARA-U2 / LISA-U2 / SARA-G3** - When <`auth_type>=3` | ~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:372:71 | 372 | /// PSM is granted by the network and an extended periodic TAU value (T3412_ext) | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 372 | /// PSM is granted by the network and an extended periodic TAU value (`T3412_ext`) | ~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:370:41 | 370 | /// PSM is granted by the network. The <Assigned_Periodic_TAU> parameter is | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 370 | /// PSM is granted by the network. The <`Assigned_Periodic_TAU`> parameter is | ~~~~~~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:368:48 | 368 | /// <n>=3 or <n>=5. The PSM related parameter <Assigned_Active_ Time> is | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 368 | /// <n>=3 or <n>=5. The PSM related parameter <`Assigned_Active`_ Time> is | ~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:367:17 | 367 | /// parameters <cause_type>, <reject_ cause>, if available, are returned when | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 367 | /// parameters <`cause_type`>, <reject_ cause>, if available, are returned when | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:365:6 | 365 | /// <rac_or_mme>, <ci> and <AcT>, if available, are returned only when <n>=2, | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 365 | /// <`rac_or_mme`>, <ci> and <AcT>, if available, are returned only when <n>=2, | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:360:49 | 360 | /// <reject_cause>, <Assigned_Active_Time> and <Assigned_Periodic_TAU> are | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 360 | /// <reject_cause>, <Assigned_Active_Time> and <`Assigned_Periodic_TAU`> are | ~~~~~~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:360:22 | 360 | /// <reject_cause>, <Assigned_Active_Time> and <Assigned_Periodic_TAU> are | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 360 | /// <reject_cause>, <`Assigned_Active_Time`> and <Assigned_Periodic_TAU> are | ~~~~~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:360:6 | 360 | /// <reject_cause>, <Assigned_Active_Time> and <Assigned_Periodic_TAU> are | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 360 | /// <`reject_cause`>, <Assigned_Active_Time> and <Assigned_Periodic_TAU> are | ~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:359:55 | 359 | /// The parameters <AcT>, <tac>, <rac_or_mme>, <ci>, <cause_type>, | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 359 | /// The parameters <AcT>, <tac>, <rac_or_mme>, <ci>, <`cause_type`>, | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:359:35 | 359 | /// The parameters <AcT>, <tac>, <rac_or_mme>, <ci>, <cause_type>, | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 359 | /// The parameters <AcT>, <tac>, <`rac_or_mme`>, <ci>, <cause_type>, | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:357:9 | 357 | /// [<Assigned_Periodic_TAU>]]]]] when <n>=5 and the value of <stat> changes | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 357 | /// [<`Assigned_Periodic_TAU`>]]]]] when <n>=5 and the value of <stat> changes | ~~~~~~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:356:74 | 356 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,[<cause_type>],[<reject_cause>][,[<Assigned_Active_Time>, | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 356 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,[<cause_type>],[<reject_cause>][,[<`Assigned_Active_Time`>, | ~~~~~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:356:56 | 356 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,[<cause_type>],[<reject_cause>][,[<Assigned_Active_Time>, | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 356 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,[<cause_type>],[<`reject_cause`>][,[<Assigned_Active_Time>, | ~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:356:41 | 356 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,[<cause_type>],[<reject_cause>][,[<Assigned_Active_Time>, | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 356 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,[<`cause_type`>],[<reject_cause>][,[<Assigned_Active_Time>, | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:353:68 | 353 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,,[,[<Assigned_Active_Time>,[<Assigned_Periodic_TAU>]]]]] | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 353 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,,[,[<Assigned_Active_Time>,[<`Assigned_Periodic_TAU`>]]]]] | ~~~~~~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:353:44 | 353 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,,[,[<Assigned_Active_Time>,[<Assigned_Periodic_TAU>]]]]] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 353 | /// <stat>[,[<tac>],[<ci>],[<AcT>][,,[,[<`Assigned_Active_Time`>,[<Assigned_Periodic_TAU>]]]]] | ~~~~~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:58:5 | 58 | ///"IPtial default bearer. Since dial-up supports only IPv4 | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 58 | ///"`IPtial` default bearer. Since dial-up supports only IPv4 | ~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:56:52 | 56 | /// test command returns a different row for each <PDP_type> value supported by | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 56 | /// test command returns a different row for each <`PDP_type`> value supported by | ~~~~~~~~~~

warning: usage of wildcard import --> ublox-cellular/src/command/psn/mod.rs:29:5 | 29 | use types::*; | ^^^^^^^^ help: try: `types::{AuthenticationType, EPSNetworkRegistrationUrcConfig, ExtendedPSNetworkRegistrationUrcConfig, GPRSAttachedState, GPRSNetworkRegistrationUrcConfig, PDPContextStatus, PSEventReportingMode, PacketSwitchedAction, PacketSwitchedNetworkDataParam, PacketSwitchedParam, PacketSwitchedParamReq}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/psn/mod.rs:28:5 | 28 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{EPSNetworkRegistrationStatus, ExtendedPSNetworkRegistrationStatus, GPRSAttached, GPRSNetworkRegistrationStatus, PDPContextState, PacketSwitchedConfig, PacketSwitchedNetworkData}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/psn/urc.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::{EPSNetworkRegistrationStat, ExtendedPSNetworkRegistrationState, GPRSNetworkRegistrationStat}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:626:24 | 626 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:604:17 | 604 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:578:24 | 578 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:570:17 | 570 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:547:24 | 547 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:533:17 | 533 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:521:17 | 521 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:512:24 | 512 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:477:24 | 477 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:461:17 | 461 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:443:17 | 443 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:429:17 | 429 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:417:17 | 417 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:403:17 | 403 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:393:17 | 393 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:381:17 | 381 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:369:17 | 369 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:200:17 | 200 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/psn/types.rs:7:17 | 7 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/psn/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::{EPSNetworkRegistrationStat, EPSNetworkRegistrationUrcConfig, ExtendedPSNetworkRegistrationState, ExtendedPSNetworkRegistrationUrcConfig, GPRSAttachedState, GPRSNetworkRegistrationStat, GPRSNetworkRegistrationUrcConfig, PDPContextStatus, PacketSwitchedNetworkDataParam, PacketSwitchedParam}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:21:65 | 21 | //! instruct the GGSN to route down-link packets onto different QoS flows | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 21 | //! instruct the GGSN to route down-link packets onto different `QoS` flows | ~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:17:50 | 17 | //! different port numbers) with a more reliable QoS. | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 17 | //! different port numbers) with a more reliable `QoS`. | ~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:15:13 | 15 | //! a given QoS (e.g. low reliability) whereas SIP signalling is routed on a | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 15 | //! a given `QoS` (e.g. low reliability) whereas SIP signalling is routed on a | ~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/psn/mod.rs:13:59 | 13 | //! The typical usage of the secondary PDP contexts is in VoIP calls, where RTP | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 13 | //! The typical usage of the secondary PDP contexts is in `VoIP` calls, where RTP | ~~~~~~

warning: usage of wildcard import --> ublox-cellular/src/command/network_service/mod.rs:11:5 | 11 | use types::*; | ^^^^^^^^ help: try: `types::{NetworkRegistrationStat, NetworkRegistrationUrcConfig, OperatorSelectionMode, RadioAccessTechnologySelected}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/network_service/mod.rs:10:5 | 10 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{NetworkRegistrationStatus, OperatorSelection, RadioAccessTechnology, SignalQuality}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/network_service/types.rs:139:24 | 139 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/network_service/types.rs:101:24 | 101 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/network_service/types.rs:71:24 | 71 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/network_service/types.rs:60:17 | 60 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/network_service/types.rs:33:30 | 33 | #[derive(Debug, Clone, Copy, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/network_service/types.rs:8:24 | 8 | #[derive(Debug, Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/network_service/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::{NetworkRegistrationStat, NetworkRegistrationUrcConfig, OperatorNameFormat, OperatorSelectionMode, RadioAccessTechnologySelected, RatAct}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: unnecessary structure name repetition --> ublox-cellular/src/command/network_service/impl_.rs:14:13 | 14 | NetworkRegistrationStat::RegistrationDenied => Err(Error::RegistrationDenied), | ^^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: this could be a `const fn` --> ublox-cellular/src/command/network_service/impl_.rs:12:5 | 12 | / pub fn registration_ok(self) -> Result<Self, Error> { 13 | | match self { 14 | | NetworkRegistrationStat::RegistrationDenied => Err(Error::RegistrationDenied), 15 | | _ => Ok(self), 16 | | } 17 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/command/network_service/impl_.rs:12:5 | 12 | pub fn registration_ok(self) -> Result<Self, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: unnecessary structure name repetition --> ublox-cellular/src/command/network_service/impl_.rs:8:51 | 8 | NetworkRegistrationStat::Registered | NetworkRegistrationStat::RegisteredRoaming | ^^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/network_service/impl_.rs:8:13 | 8 | NetworkRegistrationStat::Registered | NetworkRegistrationStat::RegisteredRoaming | ^^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: this could be a `const fn` --> ublox-cellular/src/command/network_service/impl_.rs:5:5 | 5 | / pub fn is_access_alive(&self) -> bool { 6 | | matches!( 7 | | self, 8 | | NetworkRegistrationStat::Registered | NetworkRegistrationStat::RegisteredRoaming 9 | | ) 10 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn = note: `-W clippy::missing-const-for-fn` implied by `-W clippy::nursery`

warning: this method could have a `#[must_use]` attribute --> ublox-cellular/src/command/network_service/impl_.rs:5:5 | 5 | pub fn is_access_alive(&self) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn is_access_alive(&self) -> bool` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate = note: `-W clippy::must-use-candidate` implied by `-W clippy::pedantic`

warning: usage of wildcard import --> ublox-cellular/src/command/network_service/impl_.rs:1:5 | 1 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::NetworkRegistrationStat` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/mobile_control/mod.rs:8:5 | 8 | use types::*; | ^^^^^^^^ help: try: `types::{AutomaticTimezone, Functionality, ResetMode, TerminationErrorMode}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/mobile_control/mod.rs:7:5 | 7 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{DateTime, ExtendedErrorReport, IndicatorControl, ModuleFunctionality, ReportMobileTerminationError}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/mobile_control/types.rs:211:17 | 211 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/mobile_control/types.rs:201:17 | 201 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/mobile_control/types.rs:189:17 | 189 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/mobile_control/types.rs:179:17 | 179 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/mobile_control/types.rs:165:17 | 165 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/mobile_control/types.rs:155:17 | 155 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: item in documentation is missing backticks --> ublox-cellular/src/command/mobile_control/types.rs:154:61 | 154 | /// Reset mode. This parameter can be used only when <fun> (ModuleFunctionality) is 1, 4 or 19 | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 154 | /// Reset mode. This parameter can be used only when <fun> (`ModuleFunctionality`) is 1, 4 or 19 | ~~~~~~~~~~~~~~~~~~~~~

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/mobile_control/types.rs:4:17 | 4 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/mobile_control/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::{PowerMode, ReportMobileTerminationErrorStatus, STKMode}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: item in documentation is missing backticks --> ublox-cellular/src/command/ip_transport_layer/mod.rs:175:10 | 175 | ///25.11 SendTo command (UDP only) +USOST | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 175 | ///25.11 `SendTo` command (UDP only) +USOST | ~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/ip_transport_layer/mod.rs:64:64 | 64 | /// completion of the socket close operation. By enabling the <async_close> | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 64 | /// completion of the socket close operation. By enabling the <`async_close`> | ~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/ip_transport_layer/mod.rs:39:30 | 39 | /// managed by USECMNG. The <usecmng_profile_id> parameter is listed in the | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 39 | /// managed by USECMNG. The <`usecmng_profile_id`> parameter is listed in the | ~~~~~~~~~~~~~~~~~~~~

warning: usage of wildcard import --> ublox-cellular/src/command/ip_transport_layer/mod.rs:11:5 | 11 | use types::*; | ^^^^^^^^ help: try: `types::{HexMode, SocketControlParam, SocketProtocol, SslTlsStatus}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/ip_transport_layer/mod.rs:10:5 | 10 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{CreateSocketResponse, SocketControlResponse, SocketData, SocketErrorResponse, UDPSendToDataResponse, UDPSocketData, WriteSocketDataResponse}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/ip_transport_layer/types.rs:34:17 | 34 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/ip_transport_layer/types.rs:25:17 | 25 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/ip_transport_layer/types.rs:11:17 | 11 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/ip_transport_layer/types.rs:5:17 | 5 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/ip_transport_layer/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::SocketControlParam` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: item in documentation is missing backticks --> ublox-cellular/src/command/http/mod.rs:19:16 | 19 | //! If using CellLocate® and HTTP commands HTTP profiles in the range 1-3 must | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 19 | //! If using `CellLocate`® and HTTP commands HTTP profiles in the range 1-3 must | ~~~~~~~~~~~~

warning: usage of wildcard import --> ublox-cellular/src/command/gpio/mod.rs:15:5 | 15 | use types::*; | ^^^^^^^^ help: try: `types::GpioMode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/gpio/mod.rs:14:5 | 14 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::GpioConfiguration` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/gpio/types.rs:13:17 | 13 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: item in documentation is missing backticks --> ublox-cellular/src/command/gpio/types.rs:12:43 | 12 | /// GPIO input value (for input function <gpio_mode>=1 only): | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 12 | /// GPIO input value (for input function <`gpio_mode>=1` only): | ~~~~~~~~~~~~~~

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/gpio/types.rs:6:17 | 6 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: item in documentation is missing backticks --> ublox-cellular/src/command/gpio/types.rs:5:45 | 5 | /// GPIO output value (for output function <gpio_mode>=0 only): | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 5 | /// GPIO output value (for output function <`gpio_mode>=0` only): | ~~~~~~~~~~~~~~

warning: usage of wildcard import --> ublox-cellular/src/command/gpio/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::GpioMode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/general/mod.rs:7:5 | 7 | use types::*; | ^^^^^^^^ help: try: `types::Snt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/general/mod.rs:6:5 | 6 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{CCID, CIMI, FirmwareVersion, IMEI, IdentificationInformationResponse, ManufacturerId, ModelId}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/general/types.rs:4:17 | 4 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: item in documentation is missing backticks --> ublox-cellular/src/command/file_system/mod.rs:104:31 | 104 | /// configuration, see the <tcp_data_port> parameter of the +UIFCONF AT | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 104 | /// configuration, see the <`tcp_data_port`> parameter of the +UIFCONF AT | ~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/file_system/mod.rs:82:6 | 82 | /// <op_code>, it can print: | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 82 | /// <`op_code`>, it can print: | ~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/file_system/mod.rs:48:8 | 48 | /// <tcp_data_port> parameter of the +UIFCONF AT command). After the | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 48 | /// <`tcp_data_port`> parameter of the +UIFCONF AT command). After the | ~~~~~~~~~~~~~~~

warning: usage of wildcard import --> ublox-cellular/src/command/file_system/mod.rs:10:5 | 10 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{ReadBlockResponse, ReadFileResponse}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/file_system/responses.rs:19:24 | 19 | #[derive(Clone, Debug, PartialEq, AtatResp)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/file_system/responses.rs:7:17 | 7 | #[derive(Debug, PartialEq, AtatResp)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/dns/mod.rs:21:5 | 21 | use types::*; | ^^^^^^^^ help: try: `types::ResolutionType` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/dns/mod.rs:20:5 | 20 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::ResolveNameIpResponse` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/dns/types.rs:5:17 | 5 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/dns/responses.rs:6:17 | 6 | #[derive(Clone, PartialEq, AtatResp)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/device_lock/mod.rs:8:5 | 8 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::PinStatus` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/device_lock/types.rs:3:24 | 3 | #[derive(Debug, Clone, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/device_lock/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::PinStatusCode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:128:53 | 128 | marker: core::marker::PhantomData::<PinStatusCode>, | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:19:13 | 19 | PinStatusCode::PhSimPin => Serializer::serialize_bytes(serializer, b"PH-SIM PIN"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:18:13 | 18 | PinStatusCode::PhCorpPin => Serializer::serialize_bytes(serializer, b"PH-CORP PIN"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:17:13 | 17 | PinStatusCode::PhSpPin => Serializer::serialize_bytes(serializer, b"PH-SP PIN"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:16:13 | 16 | PinStatusCode::PhNetSubPin => Serializer::serialize_bytes(serializer, b"PH-NETSUB PIN"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:15:13 | 15 | PinStatusCode::PhNetPin => Serializer::serialize_bytes(serializer, b"PH-NET PIN"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:14:13 | 14 | PinStatusCode::SimPuk2 => Serializer::serialize_bytes(serializer, b"SIM PUK2"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:13:13 | 13 | PinStatusCode::SimPin2 => Serializer::serialize_bytes(serializer, b"SIM PIN2"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:12:13 | 12 | PinStatusCode::SimPuk => Serializer::serialize_bytes(serializer, b"SIM PUK"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:11:13 | 11 | PinStatusCode::SimPin => Serializer::serialize_bytes(serializer, b"SIM PIN"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: unnecessary structure name repetition --> ublox-cellular/src/command/device_lock/impl_.rs:10:13 | 10 | PinStatusCode::Ready => Serializer::serialize_bytes(serializer, b"READY"), | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

warning: usage of wildcard import --> ublox-cellular/src/command/device_lock/impl_.rs:1:5 | 1 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::PinStatusCode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: item in documentation is missing backticks --> ublox-cellular/src/command/device_data_security/mod.rs:168:44 | 168 | /// specific security profile, issue the AT+USECPRF=<profile_id> command | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 168 | /// specific security profile, issue the `AT+USECPRF=<profile_id`> command | ~~~~~~~~~~~~~~~~~~~~~~~~

warning: usage of wildcard import --> ublox-cellular/src/command/device_data_security/mod.rs:48:5 | 48 | use types::*; | ^^^^^^^^ help: try: `types::{SecurityDataType, SecurityProfileOperation}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/command/device_data_security/mod.rs:47:5 | 47 | use responses::*; | ^^^^^^^^^^^^ help: try: `responses::{SecurityData, SecurityDataImport}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/device_data_security/types.rs:53:17 | 53 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/device_data_security/types.rs:39:17 | 39 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/device_data_security/types.rs:22:17 | 22 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/device_data_security/types.rs:7:17 | 7 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/device_data_security/responses.rs:28:17 | 28 | #[derive(Clone, PartialEq, AtatResp)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: usage of wildcard import --> ublox-cellular/src/command/device_data_security/responses.rs:2:5 | 2 | use super::types::*; | ^^^^^^^^^^^^^^^ help: try: `super::types::{SecurityDataType, SecurityOperation}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: item in documentation is missing backticks --> ublox-cellular/src/command/device_data_security/mod.rs:20:63 | 20 | //! - `AT+USECPRF`: configuration of USECMNG (u-blox SECurity MaNaGement) | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 20 | //! - `AT+USECPRF`: configuration of USECMNG (u-blox SECurity `MaNaGement`) | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> ublox-cellular/src/command/device_data_security/mod.rs:20:54 | 20 | //! - `AT+USECPRF`: configuration of USECMNG (u-blox SECurity MaNaGement) | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic` help: try | 20 | //! - `AT+USECPRF`: configuration of USECMNG (u-blox `SECurity` MaNaGement) | ~~~~~~~~~~

warning: item name ends with its containing module's name --> ublox-cellular/src/command/control/mod.rs:68:12 | 68 | pub struct SetSoftwareFlowControl { | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: item name ends with its containing module's name --> ublox-cellular/src/command/control/mod.rs:48:12 | 48 | pub struct SetFlowControl { | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions = note: `-W clippy::module-name-repetitions` implied by `-W clippy::pedantic`

warning: usage of wildcard import --> ublox-cellular/src/command/control/mod.rs:9:5 | 9 | use types::*; | ^^^^^^^^ help: try: `types::{BaudRate, Circuit108Behaviour, Circuit109Behaviour, FlowControl, SoftwareFlowControl}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/control/types.rs:54:17 | 54 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/control/types.rs:44:17 | 44 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/control/types.rs:31:17 | 31 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/control/types.rs:17:17 | 17 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq` --> ublox-cellular/src/command/control/types.rs:6:17 | 6 | #[derive(Clone, PartialEq, AtatEnum)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq = note: `-W clippy::derive-partial-eq-without-eq` implied by `-W clippy::nursery`

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/client.rs:622:5 | 622 | pub fn handle_urc<F: FnOnce(Urc) -> bool>(&mut self, f: F) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: casting `usize` to `u16` may truncate the value --> ublox-cellular/src/client.rs:587:81 | 587 | ... trace!("[Socket({})] {} bytes available", socket.0, length as u16); | ^^^^^^^^^^^^^ | = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ... = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation = note: `-W clippy::cast-possible-truncation` implied by `-W clippy::pedantic` help: ... or use `try_from` and handle the error accordingly | 587 | trace!("[Socket({})] {} bytes available", socket.0, u16::try_from(length)); | ~~~~~~~~~~~~~~~~~~~~~

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/client.rs:440:5 | 440 | pub fn initialize(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: unneeded `return` statement --> ublox-cellular/src/client.rs:429:9 | 429 | return Err(Error::Busy); | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-W clippy::needless-return` implied by `-W clippy::all` help: remove `return` | 429 - return Err(Error::Busy); 429 + Err(Error::Busy) |

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/client.rs:375:5 | 375 | / pub fn send_at<A, const LEN: usize>(&mut self, cmd: &A) -> Result<A::Response, Error> 376 | | where 377 | | A: atat::AtatCmd<LEN>, | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/client.rs:219:5 | 219 | pub fn setup_at_commands(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> ublox-cellular/src/client.rs:194:5 | 194 | pub fn spin(&mut self) -> nb::Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc = note: `-W clippy::missing-errors-doc` implied by `-W clippy::pedantic`

warning: unnecessary structure name repetition --> ublox-cellular/src/client.rs:147:26 | 147 | let mut device = Device { | ^^^^^^ help: use the applicable keyword: `Self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self = note: `-W clippy::use-self` implied by `-W clippy::nursery`

warning: usage of wildcard import --> ublox-cellular/src/client.rs:12:9 | 12 | *, | ^ help: try: `Urc, ip_transport_layer, network_service, psn, sms` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/client.rs:11:37 | 11 | system_features::{types::*, *}, | ^ help: try: `SetPowerSavingControl` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/client.rs:11:27 | 11 | system_features::{types::*, *}, | ^^^^^^^^ help: try: `types::PowerSavingMode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/client.rs:10:36 | 10 | mobile_control::{types::*, *}, | ^ help: try: `SetAutomaticTimezoneUpdate, SetModuleFunctionality, SetReportMobileTerminationError` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/client.rs:10:26 | 10 | mobile_control::{types::*, *}, | ^^^^^^^^ help: try: `types::{AutomaticTimezone, Functionality, ResetMode, TerminationErrorMode}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/client.rs:9:29 | 9 | control::{types::*, *}, | ^ help: try: `SetCircuit108Behaviour, SetCircuit109Behaviour, SetFlowControl` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> ublox-cellular/src/client.rs:9:19 | 9 | control::{types::*, *}, | ^^^^^^^^ help: try: `types::{Circuit108Behaviour, Circuit109Behaviour, FlowControl}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports = note: `-W clippy::wildcard-imports` implied by `-W clippy::pedantic`

warning: field `act` is never read --> ublox-cellular/src/registration.rs:131:5 | 128 | pub struct RegistrationParams { | ------------------ field in this struct ... 131 | act: RatAct, | ^^^ | = note: `RegistrationParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

warning: methods `started` and `updated` are never used --> ublox-cellular/src/registration.rs:39:12 | 24 | impl<const TIMER_HZ: u32> CellularRegistrationStatus<TIMER_HZ> { | -------------------------------------------------------------- methods in this implementation ... 39 | pub fn started(&self) -> Option<TimerInstantU32<TIMER_HZ>> { | ^^^^^^^ ... 43 | pub fn updated(&self) -> Option<TimerInstantU32<TIMER_HZ>> { | ^^^^^^^

warning: field `dtr_pin` is never read --> ublox-cellular/src/config.rs:36:16 | 34 | pub struct Config<RST, DTR, PWR, VINT> { | ------ field in this struct 35 | pub(crate) rst_pin: Option<RST>, 36 | pub(crate) dtr_pin: Option<DTR>, | ^^^^^^^ | = note: `Config` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: variable does not need to be mutable --> ublox-cellular/src/network.rs:411:13 | 411 | let mut new_reg_params: Option<RegistrationParams> = None; | ----^^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: unused import: `ProtocolType` --> ublox-cellular/src/services/data/mod.rs:31:45 | 31 | types::{PacketSwitchedParamReq, ProtocolType}, | ^^^^^^^^^^^^

warning: redundant else block --> ublox-cellular/src/power.rs:170:24 | 170 | } else { | ________________________^ 171 | | trace!("Modem powered on"); 172 | | } | |_________________^ | = help: remove the `else` block and move the contents out = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else

warning: this `if` statement can be collapsed --> ublox-cellular/src/network.rs:150:13 | 150 | / if !f(urc.clone()) { 151 | | if a < max { 152 | | a += 1; 153 | | return false; ... | 156 | | } 157 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `-W clippy::collapsible-if` implied by `-W clippy::all` help: collapse nested if block | 150 ~ if !f(urc.clone()) && a < max { 151 + a += 1; 152 + return false; 153 + // } else { 154 + // warn!("Dropping stale URC! {}", Debug2Format(&urc)); 155 + } |

warning: unused imports: `GetOperatorSelection`, `SetOperatorSelection`, `responses::OperatorSelection`, `types::OperatorSelectionMode` --> ublox-cellular/src/network.rs:9:13 | 9 | responses::OperatorSelection, types::OperatorSelectionMode, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 10 | GetNetworkRegistrationStatus, GetOperatorSelection, SetOperatorSelection, | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: redundant else block --> ublox-cellular/src/client.rs:246:16 | 246 | } else { | ________________^ 247 | | // Make sure AT commands parser is in clean state. 248 | | self.network.at_tx.reset()?; 249 | | self.power_on()?; 250 | | } | |_________^ | = help: remove the `else` block and move the contents out = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else = note: `-W clippy::redundant-else` implied by `-W clippy::pedantic`

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

unused imports: `GetOperatorSelection`, `SetOperatorSelection`, `responses::OperatorSelection`, `types::OperatorSelectionMode`

unused import: `ProtocolType`

variable does not need to be mutable

field `dtr_pin` is never read

methods `started` and `updated` are never used

field `act` is never read

unused `core::result::Result` that must be used

`ublox-cellular-rs` (lib) generated 7 warnings (run `cargo fix --lib -p ublox-cellular-rs` to apply 3 suggestions)

unused imports: `GetOperatorSelection`, `SetOperatorSelection`, `responses::OperatorSelection`, `types::OperatorSelectionMode`

unused import: `ProtocolType`

variable does not need to be mutable

field `dtr_pin` is never read

field `act` is never read

unused `std::result::Result` that must be used