Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize connection #2

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Stabilize connection #2

merged 2 commits into from
Oct 12, 2023

Conversation

diekleinekuh
Copy link

@diekleinekuh diekleinekuh commented Oct 5, 2023 •
edited
Loading

Removed unnecessary power_on as after a reset because of a timeout. hard_reset will set power_state to PowerState::Off and the code in initialize will take care of sending a power_on if necessary.

Changed REGISTRATION_TIMEOUT to 5min to give the modem more time to search for a network.

@diekleinekuh diekleinekuh marked this pull request as ready for review October 11, 2023 09:36
@diekleinekuh diekleinekuh merged commit cc0a30f into fix-r5 Oct 12, 2023
4 of 5 checks passed
@diekleinekuh diekleinekuh deleted the stabilize_connection branch October 12, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximeborges maximeborges maximeborges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diekleinekuh @maximeborges