-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prod container build #49
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 77.32% 77.32%
=======================================
Files 10 10
Lines 172 172
=======================================
Hits 133 133
Misses 39 39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purposes for Dockerfile and prod/Dockerfile?
The dev dockerfile is meant to be used with VSCode Dev Docker Containers: https://github.com/xmtp/xps-gateway?tab=readme-ov-file#dev-containers-development Prod is meant for running the gateway and deployment with terraform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for fixing. This makes sense no need to run the integration tests outside of the CI. It may make sense to restore the 'it' module at some later date as some folks may wish to run just the 'it's or to avoid running them as part of their test build.
🚀
waiting on xmtp/didethresolver#38fixes #47
fixes error during github pages build ('cargo test --docs -> cargo test --doc')