Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prod container build #49

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Fix prod container build #49

merged 5 commits into from
Jan 29, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Jan 29, 2024

waiting on xmtp/didethresolver#38

fixes #47

fixes error during github pages build ('cargo test --docs -> cargo test --doc')

@insipx insipx marked this pull request as ready for review January 29, 2024 16:42
@insipx insipx requested a review from jac18281828 January 29, 2024 16:42
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e83f94) 77.32% compared to head (e198371) 77.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   77.32%   77.32%           
=======================================
  Files          10       10           
  Lines         172      172           
=======================================
  Hits          133      133           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insipx insipx requested a review from 37ng January 29, 2024 16:46
Copy link
Contributor

@37ng 37ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purposes for Dockerfile and prod/Dockerfile?

@insipx
Copy link
Contributor Author

insipx commented Jan 29, 2024

What's the purposes for Dockerfile and prod/Dockerfile?

The dev dockerfile is meant to be used with VSCode Dev Docker Containers: https://github.com/xmtp/xps-gateway?tab=readme-ov-file#dev-containers-development

Prod is meant for running the gateway and deployment with terraform

prod/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for fixing. This makes sense no need to run the integration tests outside of the CI. It may make sense to restore the 'it' module at some later date as some folks may wish to run just the 'it's or to avoid running them as part of their test build.

🚀

@insipx insipx merged commit dc93376 into main Jan 29, 2024
6 checks passed
@insipx insipx deleted the insipx/prod-container branch January 29, 2024 18:48
@insipx insipx restored the insipx/prod-container branch January 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

prod container does not build
3 participants