Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46, 47: force prod ci build, upgrade codecov plugin #48

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

jac18281828
Copy link
Contributor

closes #46

related to #47

This sets the build to fail if the production container does not build

@jac18281828 jac18281828 added the enhancement New feature or request label Jan 26, 2024
@jac18281828 jac18281828 requested a review from insipx January 26, 2024 22:27
@jac18281828 jac18281828 self-assigned this Jan 26, 2024
@jac18281828
Copy link
Contributor Author

Note build is failing currently on main, @insipx

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1439a2e) 77.32% compared to head (9e83f94) 77.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   77.32%   77.32%           
=======================================
  Files          10       10           
  Lines         172      172           
=======================================
  Hits          133      133           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insipx
Copy link
Contributor

insipx commented Jan 29, 2024

#49 fixes the prod build

@jac18281828 jac18281828 merged commit 9e83f94 into main Jan 29, 2024
5 of 6 checks passed
@jac18281828 jac18281828 deleted the jac/prodci branch January 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade codecov plugin
2 participants