Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test for listing conversations from env variable account #304

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Mar 9, 2024

Fixes #305

To run the new tests, add a private key in the example/.env file from "2k lens convos test wallet" test account

TEST_PRIVATE_KEY=INSERT_TEST_PRIVATE_KEY_HERE

@cameronvoell cameronvoell force-pushed the cv/test-list-2000-accounts branch from 6907cfc to b37cd77 Compare March 9, 2024 01:58
@cameronvoell cameronvoell marked this pull request as ready for review March 9, 2024 02:01
@cameronvoell cameronvoell requested a review from a team as a code owner March 9, 2024 02:01
@cameronvoell cameronvoell marked this pull request as draft March 9, 2024 03:04
@cameronvoell cameronvoell marked this pull request as ready for review March 9, 2024 08:03
@cameronvoell cameronvoell merged commit aced04a into main Mar 11, 2024
4 of 5 checks passed
@cameronvoell cameronvoell deleted the cv/test-list-2000-accounts branch March 11, 2024 19:59
Copy link
Contributor

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: iOS conversations.list() only returns 100 conversations
2 participants