feat: Added support for handling lowercase addresses #233
Conversation
Will now get checksum addresses from provided addresses Added some helper libraries to avoid adding additional dependency on ethers
| @@ -0,0 +1,50 @@ | |||
| import { keccak_256 } from '@noble/hashes/sha3' | |||
There was a problem hiding this comment.
Port from viem getAddress
|
this change looks good, sounds like it is addressing a specific issue with adding new conversations. I wonder if we should add the new getAddress in a few more locations. For example if you pass in a lowercase address to client.contacts.deny in the test linked below, I think we will fail to block the address. Perhaps we should merge this change, but keep your issue open until we feel we have a comprehensive list of places where checksums need to added. WDYT? xmtp-react-native/example/src/tests.ts Line 676 in c68bcc5 |
Good catch, let me figure out LOE and determine |
Added handling to ensure addresses are checksums
Updated handling for contacts methods |
There was a problem hiding this comment.
Changes look good, think this PR should fully close #230 now, nice!
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Will now get checksum addresses from provided addresses Added some helper libraries to avoid adding additional dependency on ethers