Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Case Insensitive Address Checks #230

Closed
alexrisch opened this issue Jan 31, 2024 · 3 comments
Closed

Bug: Case Insensitive Address Checks #230

alexrisch opened this issue Jan 31, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@alexrisch
Copy link
Contributor

Describe the bug

Creating a conversation with lowercase address that is on the network causes an error to occur

Expected behavior

Should create a conversation regardless of casing, Related web issue: xmtp/xmtp-js#472

Steps to reproduce the bug

No response

@alexrisch alexrisch added the bug Something isn't working label Jan 31, 2024
@nplasterer
Copy link
Contributor

nplasterer commented Jan 31, 2024

I recently learned that checksum addresses is an extra level of security https://eips.ethereum.org/EIPS/eip-55 which is why addresses created are neither all lowercase or all uppercase. We can't really control what they create a client with. The address form that is. So definitely some improvement on the sdk side to not error on casing.

@cameronvoell
Copy link
Contributor

See comment here - #233 (comment) Might want to check if this needs to be fixed for consent, deny function etc.

@alexrisch
Copy link
Contributor Author

Included in version 1.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants