Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subscriptions #412

Open
wants to merge 1 commit into
base: 12-30-stub_out_new_service
Choose a base branch
from

Conversation

neekolas
Copy link
Collaborator

@neekolas neekolas commented Dec 30, 2024

TL;DR

Implemented association change notifications for MLS groups through NATS messaging system.

What changed?

  • Added support for association change notifications in the identity service
  • Implemented NATS subscription handling for association changes
  • Added new topic validation and handling for association changed messages
  • Created new topic utilities for association change management
  • Modified subscription validation to exclude association change topics from general subscriptions

How to test?

  1. Start the XMTP node with MLS enabled
  2. Subscribe to association changes using the identity service
  3. Trigger an association change in an MLS group
  4. Verify that association change notifications are received through the subscription

Why make this change?

This change enables real-time notifications when group associations change in the MLS system, allowing clients to stay synchronized with group membership changes and maintain accurate group state information.

Issues

#410

Copy link
Collaborator Author

neekolas commented Dec 30, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@neekolas neekolas force-pushed the 12-30-implement_subscriptions branch 2 times, most recently from 8462551 to 4f58a1d Compare December 31, 2024 15:10
@neekolas neekolas force-pushed the 12-30-stub_out_new_service branch from df1ba65 to fe21646 Compare December 31, 2024 15:11
@neekolas neekolas force-pushed the 12-30-implement_subscriptions branch from 4f58a1d to 4231933 Compare December 31, 2024 15:11
@neekolas neekolas marked this pull request as ready for review December 31, 2024 17:00
@neekolas neekolas requested a review from a team as a code owner December 31, 2024 17:00
@neekolas neekolas force-pushed the 12-30-implement_subscriptions branch from 4231933 to 909ce38 Compare December 31, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants