Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub out new AssociationChange API #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stub out new AssociationChange API #411

wants to merge 1 commit into from

Conversation

neekolas
Copy link
Collaborator

@neekolas neekolas commented Dec 30, 2024 •
edited
Loading

tl;dr

Add a new API to allow clients to subscribe to changes in the association state all inboxes on the network

Issues

#410

@neekolas Graphite App
Copy link
Collaborator Author

neekolas commented Dec 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@neekolas neekolas mentioned this pull request Dec 30, 2024
Open
@neekolas neekolas changed the title stub out new service Stub out new Association Changed API Dec 30, 2024
@neekolas neekolas force-pushed the 12-30-stub_out_new_service branch from df1ba65 to fe21646 Compare December 31, 2024 15:11
@neekolas neekolas mentioned this pull request Dec 31, 2024
Open
@neekolas neekolas marked this pull request as ready for review December 31, 2024 17:00
@neekolas neekolas requested a review from a team as a code owner December 31, 2024 17:00
@neekolas neekolas changed the title Stub out new Association Changed API Stub out new AssociationChange API Dec 31, 2024
richardhuaaa
richardhuaaa approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@richardhuaaa richardhuaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine, but left a clarification on the proto PR

@neekolas neekolas mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

@richardhuaaa richardhuaaa richardhuaaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neekolas @richardhuaaa @nplasterer