Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PermitWithoutStream to true #388

Merged
merged 1 commit into from
May 3, 2024
Merged

Set PermitWithoutStream to true #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/api/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,12 @@ func (s *Server) startGRPC() error {
grpc.Creds(insecure.NewCredentials()),
grpc.UnaryInterceptor(middleware.ChainUnaryServer(unary...)),
grpc.StreamInterceptor(middleware.ChainStreamServer(stream...)),
grpc.KeepaliveParams(keepalive.ServerParameters{
Time: 5 * time.Minute,
}),
grpc.KeepaliveEnforcementPolicy(keepalive.EnforcementPolicy{
MinTime: 15 * time.Second,
PermitWithoutStream: true,
MinTime: 15 * time.Second,
Copy link
Collaborator Author

@neekolas neekolas May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, @nplasterer. I just added this config setting in a previous PR to turn it to 15 seconds. Before it was set to the default of 5 minutes. I wonder how many Rust streaming problems were related to that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O wow! 🤞

}),
grpc.MaxRecvMsgSize(s.Config.Options.MaxMsgSize),
}
Expand Down
Loading