Set PermitWithoutStream to true #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
commented
May 2, 2024
| grpc.KeepaliveEnforcementPolicy(keepalive.EnforcementPolicy{ | ||
| MinTime: 15 * time.Second, | ||
| PermitWithoutStream: true, | ||
| MinTime: 15 * time.Second, |
There was a problem hiding this comment.
Also, @nplasterer. I just added this config setting in a previous PR to turn it to 15 seconds. Before it was set to the default of 5 minutes. I wonder how many Rust streaming problems were related to that.
alexrisch
approved these changes
May 2, 2024
nplasterer
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
keep_alive_while_idleset to true, but our nodes have thePermitWithoutStreamoption defaulted tofalse. When these pings come in without an open stream, the server should be sending a GOAWAY message and disconnecting. I'm surprised it isn't causing more issues, but it's safe to enable the flag on the server so we might as well try and see if it improves mobile streaming.