Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure workflow step names are consistent #635

Merged
merged 1 commit into from
Jun 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions .github/workflows/js-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ jobs:
cd packages/js-sdk
yarn format:check

node:
name: Test node
test:
name: Test
# TODO: Investigate why fetch is failing for some of these tests on warp build runners
runs-on: ubuntu-latest
steps:
Expand All @@ -101,24 +101,6 @@ jobs:
DD_SERVICE: xmtp-js
DD_CIVISIBILITY_AGENTLESS_ENABLED: 'true'
DD_API_KEY: ${{ secrets.DD_API_KEY }}

browser:
name: Test browser
# TODO: Investigate why fetch is failing for some of these tests on warp build runners
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'yarn'
env:
SKIP_YARN_COREPACK_CHECK: '1'
- name: Enable corepack
run: corepack enable
- name: Install dependencies
run: yarn
- run: ./dev/up
- run: |
cd packages/js-sdk
yarn test:browser
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/mls-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ jobs:
cd packages/mls-client
yarn format:check

test:
name: Test
runs-on: ubuntu-latest
steps:
- run: echo "No tests for MLS Client yet."

build:
name: Build
runs-on: warp-ubuntu-latest-x64-8x
Expand Down
Loading