Make sure workflow step names are consistent #635
Merged
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rygine
force-pushed
the
rygine/update-workflows
branch
from
8571785 to
ff69a69
Compare
Deploying xmtp-js-docs with
|
| Latest commit: |
ff69a69
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5fc7b8e6.xmtp-js.pages.dev |
| Branch Preview URL: | https://rygine-update-workflows.xmtp-js.pages.dev |
neekolas
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Teststep for MLS ClientTeststep for JS SDK to run both node and browser environmentsIf the
Teststep is required, it must be run. This is a limitation when using path filtering. Rulesets are supposed to help, but they don't seem to support this quite yet.We could potentially explore something like Policy Bot until GitHub sorts this out.