-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MLS Service #106
Add MLS Service #106
Conversation
@@ -49,7 +50,7 @@ lint: | |||
# MAX_LINE_LENGTH rule option. | |||
max_line_length: | |||
# Enforces a maximum line length | |||
max_chars: 80 | |||
max_chars: 150 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized that the new Protobuf formatter doesn't necessarily split lines (for example, for long RPC definitions)
@@ -0,0 +1,161 @@ | |||
// Message API | |||
syntax = "proto3"; | |||
package xmtp.message_api.v3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just skipped right over V2 and went straight to V3 for naming consistency with other V3 protos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to get something in and iterate.
One idea I'd like to plant here is if we are able to make any of these endpoints less MLS-specific? For example, by introducing a generic OrderedTopic concept, or a generic SingleUseTopic?
I'm open to ordered topics. I'd like to get a better understanding of what you'd want a Even with that, I think the |
Just spitballing, a |
🎉 This PR is included in version 3.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary