Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold MLS Server #318

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Scaffold MLS Server #318

merged 5 commits into from
Oct 23, 2023

Conversation

neekolas
Copy link
Collaborator

@neekolas neekolas commented Oct 19, 2023

Summary

Uses the new protos from this PR and creates a new GRPC service.

The new service will only run if the --api.enable-mls and --mlsstore.db-connection-string options are set. Otherwise the server should continue to behave the exact same as normal.

The service is unimplemented, and the mlsstore package doesn't do anything, but it at least puts some of the pieces in place.

Notes

I am creating a new database for the service to hold the MLS group state and key package state to separate it from the regular message storage. There are a few reasons for this:

  • Ensures that if we have unoptimized queries or bad migrations we won't break production while we are moving fast
  • Makes it easier for us just to drop the database and recreate it if we have breaking schema changes
  • Once the schema has stabilized we can always move the tables into the main DB if we think it makes sense
  • It is a logically separate service with clear boundaries to the rest of the application. We are never going to need to join between this DB and the waku db

@neekolas neekolas requested a review from snormore October 20, 2023 02:28
@neekolas neekolas merged commit 816d956 into main Oct 23, 2023
3 checks passed
@neekolas neekolas deleted the nmolnar/mls-server-scaffold branch October 23, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants