-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test only distinction for group_context_ext_proposal #22
Conversation
477c5fb
to
e6d78ba
Compare
9829e3c
to
c60736a
Compare
c60736a
to
93dc30f
Compare
7e3c125
to
e751656
Compare
7486490
to
fa33f5e
Compare
|
||
// Test functions | ||
#[cfg(test)] | ||
impl CoreGroup { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I need this for some work I have coming up too
The CI for this repo is very fussy about having documentation on any public method, so changing the visibility requires more docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it should to the trick, looks good! I just have one very minor stylistic note, but feel free to ignore that :)
@@ -1,10 +1,10 @@ | |||
use core_group::create_commit_params::CreateCommitParams; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really just a stylistic nitpick, but I'd suggest merging this line back into the use super::{...}
block below, otherwise it looks like there was a crate called "core_group".
If you need the core_group
binding later, you an do
use super::{
core_group::{self, create_commit_params::CreateCommitParams},
// ...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks fixed here 7395004
969e6a5
to
eca0be9
Compare
f172fba
to
58b8bde
Compare
Due to a recent vcpkg failure (in turn due to a bug in CMake), this PR disables interop testing with MLS++ on CI. Co-authored-by: raphaelrobert <[email protected]>
This is related to libxmtp Mutable Metadata: