Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test only distinction for group_context_ext_proposal #22

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

cameronvoell
Copy link

@cameronvoell cameronvoell commented Apr 3, 2024

@github-actions github-actions bot added the size/s label Apr 3, 2024
@github-actions github-actions bot added size/m and removed size/s labels Apr 4, 2024
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata branch from 477c5fb to e6d78ba Compare April 4, 2024 14:18
@github-actions github-actions bot added size/s and removed size/m labels Apr 4, 2024
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata branch 2 times, most recently from 9829e3c to c60736a Compare April 4, 2024 14:51
@github-actions github-actions bot added size/m and removed size/s labels Apr 4, 2024
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata branch from c60736a to 93dc30f Compare April 4, 2024 14:53
@github-actions github-actions bot added size/s and removed size/m labels Apr 4, 2024
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata branch 3 times, most recently from 7e3c125 to e751656 Compare April 4, 2024 15:44
@github-actions github-actions bot added size/m and removed size/s labels Apr 4, 2024
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata branch 3 times, most recently from 7486490 to fa33f5e Compare April 4, 2024 15:55
@github-actions github-actions bot added size/s and removed size/m labels Apr 4, 2024
@github-actions github-actions bot added size/m and removed size/s labels Apr 9, 2024
@cameronvoell cameronvoell marked this pull request as ready for review April 10, 2024 06:39

// Test functions
#[cfg(test)]
impl CoreGroup {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I need this for some work I have coming up too

@neekolas
Copy link

The CI for this repo is very fussy about having documentation on any public method, so changing the visibility requires more docs.

Copy link

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should to the trick, looks good! I just have one very minor stylistic note, but feel free to ignore that :)

@@ -1,10 +1,10 @@
use core_group::create_commit_params::CreateCommitParams;
Copy link

@keks keks Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really just a stylistic nitpick, but I'd suggest merging this line back into the use super::{...} block below, otherwise it looks like there was a crate called "core_group".

If you need the core_group binding later, you an do

use super::{
  core_group::{self, create_commit_params::CreateCommitParams},
  // ...
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks fixed here 7395004

raphaelrobert and others added 2 commits April 10, 2024 12:43
Due to a recent vcpkg failure (in turn due to a bug in CMake), this PR disables interop testing with MLS++ on CI.

Co-authored-by: raphaelrobert <[email protected]>
@cameronvoell cameronvoell merged commit 9288932 into main Apr 10, 2024
51 checks passed
@cameronvoell cameronvoell deleted the cv/mutable-metadata branch April 10, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants