Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable Metadata group name Part 2 #644

Merged
merged 11 commits into from
Apr 19, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Apr 10, 2024

We would like to have a metadata extension type that can be modified after group creation. This is possible using the Unknown Group Context Extension type, which accepts a byte array as the only field. See #548 for more info.

Related PR's:

Before merging this to main:

  • Update openmls reference in Cargo.toml to commit on xmtp/openmls main branch
  • Update dev/gen_protos.sh to point to xmtp-proto repo main branch

@cameronvoell cameronvoell marked this pull request as ready for review April 10, 2024 06:44
@cameronvoell cameronvoell requested a review from a team as a code owner April 10, 2024 06:44
@insipx
Copy link
Contributor

insipx commented Apr 10, 2024

Something cool that nick found was using graphite to manage prs in parts like this, found it super useful so far in case you're interested, graphite

xmtp_mls/src/groups/mod.rs Outdated Show resolved Hide resolved
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata-group-name-part-1 branch from eb1143e to a236ed4 Compare April 12, 2024 22:10
Base automatically changed from cv/mutable-metadata-group-name-part-1 to main April 12, 2024 23:28
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata-group-name-part-2 branch from dfe225e to 29847dc Compare April 12, 2024 23:43
@cameronvoell cameronvoell force-pushed the cv/mutable-metadata-group-name-part-2 branch 2 times, most recently from 28df410 to 11d8841 Compare April 15, 2024 22:49
@nplasterer nplasterer requested a review from a team April 18, 2024 16:58
@cameronvoell cameronvoell merged commit 4018fa0 into main Apr 19, 2024
6 checks passed
@cameronvoell cameronvoell deleted the cv/mutable-metadata-group-name-part-2 branch April 19, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants