-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutable Metadata group name Part 2 #644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Something cool that nick found was using |
insipx
reviewed
Apr 10, 2024
neekolas
reviewed
Apr 10, 2024
cameronvoell
force-pushed
the
cv/mutable-metadata-group-name-part-1
branch
from
April 12, 2024 22:10
eb1143e
to
a236ed4
Compare
cameronvoell
force-pushed
the
cv/mutable-metadata-group-name-part-2
branch
from
April 12, 2024 23:43
dfe225e
to
29847dc
Compare
cameronvoell
force-pushed
the
cv/mutable-metadata-group-name-part-2
branch
2 times, most recently
from
April 15, 2024 22:49
28df410
to
11d8841
Compare
2 tasks
neekolas
approved these changes
Apr 18, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to have a metadata extension type that can be modified after group creation. This is possible using the Unknown Group Context Extension type, which accepts a byte array as the only field. See #548 for more info.
Related PR's:
Before merging this to
main
:Cargo.toml
to commit onxmtp/openmls
main
branchxmtp-proto
repomain
branch