Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/… #972
workspace
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.77.2 (25ef9e3d8 2024-04-09)
- cargo 1.77.2 (e52e36006 2024-03-26)
- clippy 0.1.77 (25ef9e3 2024-04-09)
Annotations
Check warning on line 179 in xmtp_id/src/associations/serialization.rs
github-actions / workspace
unneeded `return` statement
warning: unneeded `return` statement
--> xmtp_id/src/associations/serialization.rs:179:17
|
179 | None => return Err(DeserializationError::MissingSignature),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
179 | None => Err(DeserializationError::MissingSignature),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 159 in xmtp_id/src/associations/serialization.rs
github-actions / workspace
unneeded `return` statement
warning: unneeded `return` statement
--> xmtp_id/src/associations/serialization.rs:159:17
|
159 | None => return Err(DeserializationError::MissingMemberIdentifier),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
159 | None => Err(DeserializationError::MissingMemberIdentifier),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 112 in xmtp_id/src/associations/serialization.rs
github-actions / workspace
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> xmtp_id/src/associations/serialization.rs:112:14
|
112 | actions: &Vec<IdentityActionKindProto>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[IdentityActionKindProto]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Check warning on line 35 in xmtp_id/src/associations/serialization.rs
github-actions / workspace
all variants have the same prefix: `Missing`
warning: all variants have the same prefix: `Missing`
--> xmtp_id/src/associations/serialization.rs:28:1
|
28 | / pub enum DeserializationError {
29 | | #[error("Missing action")]
30 | | MissingAction,
31 | | #[error("Missing member identifier")]
... |
34 | | MissingSignature,
35 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default