Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/… #972
neekolasAnnotations
1 error and 7 warnings
|
build
buildx failed with: ERROR: failed to solve: process "/bin/sh -c cargo clippy --all-features --no-deps -- -Dwarnings" did not complete successfully: exit code: 101
|
|
unneeded `return` statement:
xmtp_id/src/associations/serialization.rs#L179
warning: unneeded `return` statement
--> xmtp_id/src/associations/serialization.rs:179:17
|
179 | None => return Err(DeserializationError::MissingSignature),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
179 | None => Err(DeserializationError::MissingSignature),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
unneeded `return` statement:
xmtp_id/src/associations/serialization.rs#L159
warning: unneeded `return` statement
--> xmtp_id/src/associations/serialization.rs:159:17
|
159 | None => return Err(DeserializationError::MissingMemberIdentifier),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
159 | None => Err(DeserializationError::MissingMemberIdentifier),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
xmtp_id/src/associations/serialization.rs#L112
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> xmtp_id/src/associations/serialization.rs:112:14
|
112 | actions: &Vec<IdentityActionKindProto>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[IdentityActionKindProto]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
all variants have the same prefix: `Missing`:
xmtp_id/src/associations/serialization.rs#L28
warning: all variants have the same prefix: `Missing`
--> xmtp_id/src/associations/serialization.rs:28:1
|
28 | / pub enum DeserializationError {
29 | | #[error("Missing action")]
30 | | MissingAction,
31 | | #[error("Missing member identifier")]
... |
34 | | MissingSignature,
35 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
|
|
build
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.314.1. Please update to the latest version 2.315.0
|
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/build-push-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
this function has too many arguments (8/7):
src/mls.rs#L49
warning: this function has too many arguments (8/7)
--> src/mls.rs:49:1
|
49 | / pub async fn create_client(
50 | | logger: Box<dyn FfiLogger>,
51 | | host: String,
52 | | is_secure: bool,
... |
57 | | legacy_signed_private_key_proto: Option<Vec<u8>>,
58 | | ) -> Result<Arc<FfiXmtpClient>, GenericError> {
| |_____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|