Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds functions for creating a DM group #901

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Jul 14, 2024

Part of #693

DM Permissions setup:

  1. We create a group with new immutable DM Members fields (two unordered inboxes)
  2. For DM groups, you can always add a member with one of the two inbox ids
  3. adding anyone else or removing is set to deny
  4. there are no admins or super admins
  5. both members can update all mutable metadata

Before Merging:

  • set dev/gen_protos.sh back to main branch

@cameronvoell cameronvoell changed the base branch from main to mls-dm-release July 26, 2024 19:59
@cameronvoell cameronvoell marked this pull request as ready for review July 30, 2024 14:59
@cameronvoell cameronvoell requested a review from a team as a code owner July 30, 2024 14:59
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to start the long running dm branch. 👍

@cameronvoell cameronvoell merged commit bf8f0f2 into mls-dm-release Jul 30, 2024
6 checks passed
@cameronvoell cameronvoell deleted the cv/dm-permissions branch July 30, 2024 15:23
nplasterer added a commit that referenced this pull request Oct 1, 2024
* Adds functions for creating a DM group (#901)

* update bindings cargo locks

* Added dm group functionality

* dm members can update all metadata

* fix tests

* fix indentation

* fix test imports

* gen protos back to main

---------

Co-authored-by: cameronvoell <[email protected]>

* Private Preferences DB (#946)

* create the database migration for the private preference work

* update the table to be focused on consent

* first pass at database storage structure

* update the get method for consent records

* fix up the set method

* add a test

* fix up the test

* fix up the clippy error with consent record

* fix up the clippy error with consent record

* fix up all clippy issues

* cargo fmt

* Validate dm group metadata + permissions from welcome (#1075)

* validate dm group before creating from welcome

* lint fix

* lint fix

---------

Co-authored-by: cameronvoell <[email protected]>

* fixes after merge

* DM updates - default to not displaying dm groups (#1046)

* bindings create_dm function

* find groups by default does not include dm groups

* fmt fix

* dont execute callbacks when dm group welcomes are streamed

* Update bindings_ffi/src/mls.rs

Co-authored-by: Andrew Plaza <[email protected]>

* fixed bad merge

* filter dms in stream_conversations

* surface include_dm_groups in bindings list function more clearly

---------

Co-authored-by: cameronvoell <[email protected]>
Co-authored-by: Andrew Plaza <[email protected]>

* fix merge conflicts

* cargo clippy

* Remove tracing from test

* Fix test

* try and fix the tests

* fix up the test

---------

Co-authored-by: cameronvoell <[email protected]>
Co-authored-by: Naomi Plasterer <[email protected]>
Co-authored-by: Andrew Plaza <[email protected]>
Co-authored-by: Ry Racherbaumer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants