MLS Dms - Dual Sending Pre-requisites #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update bindings cargo locks * Added dm group functionality * dm members can update all metadata * fix tests * fix indentation * fix test imports * gen protos back to main --------- Co-authored-by: cameronvoell <[email protected]>
* create the database migration for the private preference work * update the table to be focused on consent * first pass at database storage structure * update the get method for consent records * fix up the set method * add a test * fix up the test * fix up the clippy error with consent record * fix up the clippy error with consent record * fix up all clippy issues * cargo fmt
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
* validate dm group before creating from welcome * lint fix * lint fix --------- Co-authored-by: cameronvoell <[email protected]>
* bindings create_dm function * find groups by default does not include dm groups * fmt fix * dont execute callbacks when dm group welcomes are streamed * Update bindings_ffi/src/mls.rs Co-authored-by: Andrew Plaza <[email protected]> * fixed bad merge * filter dms in stream_conversations * surface include_dm_groups in bindings list function more clearly --------- Co-authored-by: cameronvoell <[email protected]> Co-authored-by: Andrew Plaza <[email protected]>
nplasterer
reviewed
Sep 30, 2024
rygine
reviewed
Sep 30, 2024
nplasterer
approved these changes
Sep 30, 2024
insipx
approved these changes
Oct 1, 2024
rygine
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1074
This feature branch fulfills the pre-requisites for libxmtp clients before the "Dual Sending" phase of our migration from 1 to 1 messages as V2 Conversations, to having all 1 to 1 messages being backed by V3 MLS DM Groups.
This feature branch encorporates the following three PRs: