fix: xline watcher will loss event #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #678 +/- ##
==========================================
+ Coverage 74.36% 74.90% +0.53%
==========================================
Files 170 172 +2
Lines 24834 25375 +541
Branches 24834 25375 +541
==========================================
+ Hits 18467 19006 +539
+ Misses 5225 5175 -50
- Partials 1142 1194 +52 ☔ View full report in Codecov by Sentry. |
Phoenix500526
force-pushed
the
fix/watch-event-loss
branch
from
f2e3021 to
b9202df
Compare
bsbds
reviewed
Mar 8, 2024
Phoenix500526
force-pushed
the
fix/watch-event-loss
branch
from
b9202df to
f769203
Compare
Closes: xline-kv#677 Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
fix/watch-event-loss
branch
from
f769203 to
79a4c9e
Compare
Phoenix500526
changed the title
bsbds
approved these changes
Mar 11, 2024
|
have build the image on this PR and tested with #403 (single kubernetes cluster and single xline ),always success. (CI failed with too big log of xline debug for upload artifact) |
rogercloud
approved these changes
Mar 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #677
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Add a HashSet to track all notified revision.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)