Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push the latest image on push master. #802

Merged
merged 1 commit into from
May 9, 2024

Conversation

liangyuanpeng
Copy link
Contributor

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

Push the latest image for let people can be experience the master branch function in advance.

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@mergify mergify bot requested a review from a team May 2, 2024 07:22
Copy link

mergify bot commented May 2, 2024

@liangyuanpeng You've modified the workflows. Please don't forget to update the .mergify.yml.

Copy link

mergify bot commented May 2, 2024

@liangyuanpeng Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft May 2, 2024 07:23
@liangyuanpeng liangyuanpeng force-pushed the release_latest_image branch from 2ed29d3 to 5025f79 Compare May 2, 2024 07:26
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.59%. Comparing base (e35b35a) to head (5025f79).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   75.55%   75.59%   +0.04%     
==========================================
  Files         180      187       +7     
  Lines       26938    27563     +625     
  Branches    26938    27563     +625     
==========================================
+ Hits        20353    20837     +484     
- Misses       5366     5448      +82     
- Partials     1219     1278      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng liangyuanpeng marked this pull request as ready for review May 2, 2024 09:55
@mergify mergify bot requested a review from a team May 5, 2024 03:21
@Phoenix500526
Copy link
Collaborator

IMO, it's better to provide a script to build the latest image from the master branch rather than to build an image from the master branch and push it into our image repo. It will upload many images that are unstable to our image repo. It may not be a good practice.

@Phoenix500526
Copy link
Collaborator

Phoenix500526 commented May 9, 2024

@liangyuanpeng BTW, I am confused with these three workflows: merge_image.yml, release.yml, and docker_image.yml. The docker_image.yml workflow has not been triggered since it was created. Do you have any interest in refactoring them?

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented May 9, 2024

It will upload many images that are unstable to our image repo.

It only "one" image---latest, the user should know that this is "The latest" image and not a stable image.

I would say this is a universal need. --> "I just want to use it and don't want to build it."

The docker_image.yml workflow has not been triggered since it was created.

I used this workflow to created the image for PR fix: xline watcher will loss event on my fork repo, see https://github.com/liangyuanpeng/Xline/actions/runs/8244904769

Do you have any interest in refactoring them?

please create a issue for it and i will pick it up when i have a time, or welcome everyone contribute.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit dca4449 into xline-kv:master May 9, 2024
14 checks passed
@mergify mergify bot requested a review from a team May 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants