-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push the latest image on push master. #802
Conversation
@liangyuanpeng You've modified the workflows. Please don't forget to update the .mergify.yml. |
@liangyuanpeng Convert your pr to draft since CI failed |
Signed-off-by: Lan Liang <[email protected]>
2ed29d3
to
5025f79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 75.55% 75.59% +0.04%
==========================================
Files 180 187 +7
Lines 26938 27563 +625
Branches 26938 27563 +625
==========================================
+ Hits 20353 20837 +484
- Misses 5366 5448 +82
- Partials 1219 1278 +59 ☔ View full report in Codecov by Sentry. |
IMO, it's better to provide a script to build the latest image from the master branch rather than to build an image from the master branch and push it into our image repo. It will upload many images that are unstable to our image repo. It may not be a good practice. |
@liangyuanpeng BTW, I am confused with these three workflows: merge_image.yml, release.yml, and docker_image.yml. The docker_image.yml workflow has not been triggered since it was created. Do you have any interest in refactoring them? |
It only "one" image---latest, the user should know that this is "The latest" image and not a stable image. I would say this is a universal need. --> "I just want to use it and don't want to build it."
I used this workflow to created the image for PR fix: xline watcher will loss event on my fork repo, see https://github.com/liangyuanpeng/Xline/actions/runs/8244904769
please create a issue for it and i will pick it up when i have a time, or welcome everyone contribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please briefly answer these questions:
Push the latest image for let people can be experience the master branch function in advance.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)