Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows and macos to CI #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add windows and macos to CI #91

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abd1d44
Added windows and macos to CI
ShouvikGhosh2048 Jan 13, 2023
b229a3f
Update version
ShouvikGhosh2048 Jan 13, 2023
93bb803
Revert back to Julia version 1
ShouvikGhosh2048 Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,20 @@ on:
# can add tags if needed

jobs:
test:
name: Test
runs-on: ubuntu-latest
test:
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
version: ['1.7.2']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShouvikGhosh2048 here can you change the version to just ['1']? I think our recent tests are in 1.8.x, and this might be making the tests fail.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu fails on 1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to run the test on version 1.8.x?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourish-cmi Yes, with version being ['1'] the CI will get the latest version of Julia. The most recent test was done in 1.8.5: https://github.com/xKDR/CRRao.jl/actions/runs/3978462222/jobs/6820258360

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

os: [ubuntu-latest, windows-latest, macos-latest]
arch: [x64]
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@latest
with:
version: '1.7.2'
arch: x64
- name: Install test dependencies
run: julia --project=test/ -e 'using Pkg; Pkg.instantiate()'
- name: Run tests
run: julia --project=. -e 'using Pkg; Pkg.test()'
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/cache@v1
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1